Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 1420943003: [Ozone-DRM] Fix double call of swap buffers callback on failure (Closed)

Created:
5 years, 1 month ago by oshima
Modified:
5 years, 1 month ago
Reviewers:
dnicoara
CC:
chromium-reviews, asanka, kalyank, benjhayden+dwatch_chromium.org, piman+watch_chromium.org, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2526
Target Ref:
refs/pending/branch-heads/2526
Project:
chromium
Visibility:
Public.

Description

[Ozone-DRM] Fix double call of swap buffers callback on failure The HardwareDisplayController handles all cases and should call the callback even on failure. Make sure this happens otherwise we signal failed swaps twice. BUG=537836 TBR=dnicoara@chromium.org Review URL: https://codereview.chromium.org/1417423002 Cr-Commit-Position: refs/heads/master@{#355815} (cherry picked from commit aebd8ebe5cccb7fce8f446db01f8e9bea8176435) Committed: https://chromium.googlesource.com/chromium/src/+/e223245d89e192c153b0107565e9722226589f23

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -5 lines) Patch
M ui/ozone/platform/drm/gpu/drm_window.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M ui/ozone/platform/drm/gpu/drm_window_unittest.cc View 3 chunks +35 lines, -0 lines 0 comments Download
M ui/ozone/platform/drm/gpu/hardware_display_controller.cc View 1 chunk +3 lines, -1 line 0 comments Download
M ui/ozone/platform/drm/gpu/hardware_display_controller_unittest.cc View 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
oshima
5 years, 1 month ago (2015-10-26 18:57:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1420943003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1420943003/1
5 years, 1 month ago (2015-10-26 18:58:53 UTC) #3
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
5 years, 1 month ago (2015-10-26 18:58:54 UTC) #5
oshima
5 years, 1 month ago (2015-10-26 19:14:40 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e223245d89e192c153b0107565e9722226589f23 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698