ui/ozone/platform/drm/gpu/hardware_display_controller.cc - Issue 1420943003: [Ozone-DRM] Fix double call of swap buffers callback on failure

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/ozone/platform/drm/gpu/hardware_display_controller.cc

Issue 1420943003: [Ozone-DRM] Fix double call of swap buffers callback on failure (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2526

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ui/ozone/platform/drm/gpu/drm_window_unittest.cc ('k') | ui/ozone/platform/drm/gpu/hardware_display_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/ozone/platform/drm/gpu/hardware_display_controller.cc

diff --git a/ui/ozone/platform/drm/gpu/hardware_display_controller.cc b/ui/ozone/platform/drm/gpu/hardware_display_controller.cc

index fde972c247434e6abcdfa712215a8e188dc7f411..a377e8bafa46547689d804528413d9db7ff6a9a2 100644

--- a/ui/ozone/platform/drm/gpu/hardware_display_controller.cc

+++ b/ui/ozone/platform/drm/gpu/hardware_display_controller.cc

@@ -94,8 +94,10 @@ bool HardwareDisplayController::SchedulePageFlip(

[](const OverlayPlane& l, const OverlayPlane& r) {

return l.z_order < r.z_order;

});

- if (pending_planes.front().z_order != 0)

+ if (pending_planes.front().z_order != 0) {

+ callback.Run(gfx::SwapResult::SWAP_FAILED);

return false;

+ }

for (const auto& planes : owned_hardware_planes_)

planes.first->plane_manager()->BeginFrame(planes.second);