[Ozone-DRM] Fix double call of swap buffers callback on failure

[Ozone-DRM] Fix double call of swap buffers callback on failure

The HardwareDisplayController handles all cases and should call the
callback even on failure. Make sure this happens otherwise we signal
failed swaps twice.

BUG=537836
Committed: https://crrev.com/aebd8ebe5cccb7fce8f446db01f8e9bea8176435
Cr-Commit-Position: refs/heads/master@{#355815}

[dnicoara, 2015-10-23 16:05:10]

dnicoara@chromium.org changed reviewers:
+ spang@chromium.org

[dnicoara, 2015-10-23 16:05:10]

PTAL

[dnicoara, 2015-10-23 16:05:16]

The CQ bit was checked by dnicoara@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-23 16:05:52]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1417423002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1417423002/1

[spang, 2015-10-23 16:18:35]

Ugh. This API is bad and we should feel bad. We should not be returning an
boolean error status from a function that can fail asynchronously. I've
mentioned this before and now it's caused a horrible bug.

lgtm. Let's fix the API.

[dnicoara, 2015-10-23 16:22:28]

On 2015/10/23 16:18:35, spang wrote:
> Ugh. This API is bad and we should feel bad. We should not be returning an
> boolean error status from a function that can fail asynchronously. I've
> mentioned this before and now it's caused a horrible bug.
> 
> lgtm. Let's fix the API.

Agreed. I'll have some followup changes to remove the returned bool.

[commit-bot: I haz the power, 2015-10-23 16:34:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-23 16:34:33]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dnicoara, 2015-10-23 17:07:36]

The CQ bit was checked by dnicoara@chromium.org

[dnicoara, 2015-10-23 17:07:36]

The patchset sent to the CQ was uploaded after l-g-t-m from spang@chromium.org
Link to the patchset: https://codereview.chromium.org/1417423002/#ps20001
(title: "rebased")

[commit-bot: I haz the power, 2015-10-23 17:07:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1417423002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1417423002/20001

[commit-bot: I haz the power, 2015-10-23 17:23:54]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-10-23 17:25:59]

Patchset 2 (id:??) landed as
https://crrev.com/aebd8ebe5cccb7fce8f446db01f8e9bea8176435
Cr-Commit-Position: refs/heads/master@{#355815}