[MD settings] change dropdown to accept array of objects rather than array of tuples

[MD settings] change dropdown to accept array of objects rather than array of tuples

This is an optional CL.  There was a question from Micael about using named keys
for the menu options rather than an array index.  This CL shows what that would
look like.

Performance side-effect: inconsequential (measured by hand).

BUG=531786
Committed: https://crrev.com/8bea8800993569264106223337a53ec02001b342
Cr-Commit-Position: refs/heads/master@{#361390}

[dschuyler, 2015-11-10 22:13:53]

Description was changed from

==========
[MD settings] change dropdown to accept array of objects rather than array of
tuples

This is an optional CL.  There was a question from Micael about using named keys
for the menu options rather than an array index.  This CL shows what that would
look like.

BUG=531786
==========

to

==========
[MD settings] change dropdown to accept array of objects rather than array of
tuples

This is an optional CL.  There was a question from Micael about using named keys
for the menu options rather than an array index.  This CL shows what that would
look like.

BUG=531786
==========

[dschuyler, 2015-11-10 22:13:53]

dschuyler@chromium.org changed reviewers:
+ michaelpg@chromium.org

[michaelpg, 2015-11-20 15:10:29]

Would you mind rebasing this, or shall I?

[dschuyler, 2015-11-20 17:37:50]

On 2015/11/20 15:10:29, michaelpg wrote:
> Would you mind rebasing this, or shall I?

I should be able to do it today.

[dschuyler, 2015-11-20 23:06:53]

PTAL

[michaelpg, 2015-11-21 00:02:28]

lgtm

https://codereview.chromium.org/1420533011/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/appearance_page/appearance_page.js
(right):

https://codereview.chromium.org/1420533011/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/appearance_page/appearance_page.js:118:
chrome.settingsPrivate.getDefaultZoomPercent(
hmm, won't we need a listener for changes to the default zoom percent in Chrome?
If that requires an API change, can you add a TODO here?

[dschuyler, 2015-11-21 01:34:41]

https://codereview.chromium.org/1420533011/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/appearance_page/appearance_page.js
(right):

https://codereview.chromium.org/1420533011/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/appearance_page/appearance_page.js:118:
chrome.settingsPrivate.getDefaultZoomPercent(
On 2015/11/21 00:02:28, michaelpg wrote:
> hmm, won't we need a listener for changes to the default zoom percent in
Chrome?
> If that requires an API change, can you add a TODO here?

Done.

[dschuyler, 2015-11-23 19:47:57]

Description was changed from

==========
[MD settings] change dropdown to accept array of objects rather than array of
tuples

This is an optional CL.  There was a question from Micael about using named keys
for the menu options rather than an array index.  This CL shows what that would
look like.

BUG=531786
==========

to

==========
[MD settings] change dropdown to accept array of objects rather than array of
tuples

This is an optional CL.  There was a question from Micael about using named keys
for the menu options rather than an array index.  This CL shows what that would
look like.

Performance side-effect: inconsequential (measured by hand).

BUG=531786
==========

[dschuyler, 2015-11-24 18:16:08]

The CQ bit was checked by dschuyler@chromium.org

[dschuyler, 2015-11-24 18:16:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaelpg@chromium.org
Link to the patchset: https://codereview.chromium.org/1420533011/#ps100001
(title: "trybot fix")

[commit-bot: I haz the power, 2015-11-24 18:17:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1420533011/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1420533011/100001

[commit-bot: I haz the power, 2015-11-24 18:25:10]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-11-24 18:26:53]

Patchset 6 (id:??) landed as
https://crrev.com/8bea8800993569264106223337a53ec02001b342
Cr-Commit-Position: refs/heads/master@{#361390}