chrome/browser/resources/settings/clear_browsing_data_page/clear_browsing_data_page.js - Issue 1420533011: [MD settings] change dropdown to accept array of objects rather than array of tuples

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/clear_browsing_data_page/clear_browsing_data_page.js

Issue 1420533011: [MD settings] change dropdown to accept array of objects rather than array of tuples (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@appearance50p

Patch Set: trybot fix Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/clear_browsing_data_page/clear_browsing_data_page.html ('k') | chrome/browser/resources/settings/controls/compiled_resources.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/clear_browsing_data_page/clear_browsing_data_page.js

diff --git a/chrome/browser/resources/settings/clear_browsing_data_page/clear_browsing_data_page.js b/chrome/browser/resources/settings/clear_browsing_data_page/clear_browsing_data_page.js

index b60dd61252bf1a047e230685902980b0236b67b8..5a9b14c2c61c0bdc9027ebcaaa5f5d433c7240e6 100644

--- a/chrome/browser/resources/settings/clear_browsing_data_page/clear_browsing_data_page.js

+++ b/chrome/browser/resources/settings/clear_browsing_data_page/clear_browsing_data_page.js

@@ -40,19 +40,17 @@ Polymer({

/**

* List of options for the dropdown menu.

- * The order of entries in this array matches the

- * prefs.browser.clear_data.time_period.value enum.

- * @private {!Array<!Array<number, string>>}

+ * @private {!DropdownMenuOptionList>}

clearFromOptions_: {

readOnly: true,

type: Array,

value: [

- [0, loadTimeData.getString('clearDataHour')],

- [1, loadTimeData.getString('clearDataDay')],

- [2, loadTimeData.getString('clearDataWeek')],

- [3, loadTimeData.getString('clearData4Weeks')],

- [4, loadTimeData.getString('clearDataEverything')],

+ {value: 0, name: loadTimeData.getString('clearDataHour')},

+ {value: 1, name: loadTimeData.getString('clearDataDay')},

+ {value: 2, name: loadTimeData.getString('clearDataWeek')},

+ {value: 3, name: loadTimeData.getString('clearData4Weeks')},

+ {value: 4, name: loadTimeData.getString('clearDataEverything')},