chrome/browser/resources/settings/controls/settings_dropdown_menu.html - Issue 1420533011: [MD settings] change dropdown to accept array of objects rather than array of tuples

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/controls/settings_dropdown_menu.html

Issue 1420533011: [MD settings] change dropdown to accept array of objects rather than array of tuples (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@appearance50p

Patch Set: trybot fix Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/controls/compiled_resources.gyp ('k') | chrome/browser/resources/settings/controls/settings_dropdown_menu.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/controls/settings_dropdown_menu.html

diff --git a/chrome/browser/resources/settings/controls/settings_dropdown_menu.html b/chrome/browser/resources/settings/controls/settings_dropdown_menu.html

index 2c7964211e7ec6e98c8843dfed49bf39b3b407a2..4e7719328cbbb031a55e01d981301f8df3cc1063 100644

--- a/chrome/browser/resources/settings/controls/settings_dropdown_menu.html

+++ b/chrome/browser/resources/settings/controls/settings_dropdown_menu.html

@@ -15,7 +15,7 @@

<paper-menu class="dropdown-content" selected="{{selected_}}"

attr-for-selected="data-value">

- <paper-item data-value$="[[item.0]]">[[item.1]]</paper-item>

+ <paper-item data-value$="[[item.value]]">[[item.name]]</paper-item>

</template>

<paper-item data-value$="[[notFoundValue_]]"

hidden$="[[!isSelectedNotFound_(selected_)]]">