Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 1408343010: [MD settings] closure fixes for appearance_font_menu and allowResetTheme (Closed)

Created:
5 years, 1 month ago by dschuyler
Modified:
5 years, 1 month ago
Reviewers:
Dan Beam
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, jlklein+watch-closure_chromium.org, arv+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, dbeam+watch-closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] closure fixes for appearance_font_menu and allowResetTheme The appearance_font_menu was removed and I hadn't removed the closure build refrence to it. The allowResetTheme_ was also causing a closure error because it was defined twice. BUG=531786 Committed: https://crrev.com/0efebaf31c5e8ba1a7b96579121d2c77f3419b07 Cr-Commit-Position: refs/heads/master@{#358497}

Patch Set 1 #

Messages

Total messages: 8 (3 generated)
dschuyler
5 years, 1 month ago (2015-11-07 01:22:05 UTC) #3
Dan Beam
lgtm
5 years, 1 month ago (2015-11-07 01:24:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1408343010/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1408343010/1
5 years, 1 month ago (2015-11-07 01:26:49 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-07 02:07:12 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-07 02:08:07 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0efebaf31c5e8ba1a7b96579121d2c77f3419b07
Cr-Commit-Position: refs/heads/master@{#358497}

Powered by Google App Engine
This is Rietveld 408576698