Corrects cleanup on an error during Process startup

Corrects cleanup on an error during Process startup

BUG=

[zra, 2015-10-19 22:07:26]

zra@google.com changed reviewers:
+ iposva@google.com, johnmccutchan@google.com, whesse@google.com

[zra, 2015-10-19 22:07:26]

This is the patch against the stable branch for the memory leak fix.

[Cutch, 2015-10-19 22:09:13]

lgtm

[Bill Hesse, 2015-10-19 22:49:42]

OK, please file a MergeToStable issue for this, and I'll make a release.  I
assume this is worth doing a stable patch release for?  We are nearing the
release of stable 1.13.

[Ivan Posva, 2015-10-20 06:39:13]

DBC

-Ivan

https://codereview.chromium.org/1420443002/diff/1/runtime/bin/process_patch.dart
File runtime/bin/process_patch.dart (right):

https://codereview.chromium.org/1420443002/diff/1/runtime/bin/process_patch.d...
runtime/bin/process_patch.dart:198: throw new ArgumentError("Path is not a
String: $path");
Here?

https://codereview.chromium.org/1420443002/diff/1/runtime/bin/process_patch.d...
runtime/bin/process_patch.dart:203: throw new ArgumentError("Arguments is not a
List: $arguments");
And here?

https://codereview.chromium.org/1420443002/diff/1/runtime/bin/process_patch.d...
runtime/bin/process_patch.dart:210: throw new ArgumentError("Non-string
argument: $arg");
And many more places?

[zra, 2015-10-20 16:03:26]

https://codereview.chromium.org/1420443002/diff/1/runtime/bin/process_patch.dart
File runtime/bin/process_patch.dart (right):

https://codereview.chromium.org/1420443002/diff/1/runtime/bin/process_patch.d...
runtime/bin/process_patch.dart:198: throw new ArgumentError("Path is not a
String: $path");
On 2015/10/20 06:39:12, Ivan Posva wrote:
> Here?

As discussed, we no longer populate the map.

[Cutch, 2015-10-20 16:05:38]

lgtm

[kevmoo, 2015-10-21 17:10:57]

kevmoo@google.com changed reviewers:
+ kevmoo@google.com

[kevmoo, 2015-10-21 17:10:57]

Did this land?

https://github.com/dart-lang/sdk/commit/e6d92100bf2936907c891a17f934995c59017111

Weird to see it open.

Is there a description of the fix we can put in the changelog?
https://github.com/dart-lang/sdk/issues/24675

[Ivan Posva, 2015-10-22 05:29:32]

On 2015/10/21 17:10:57, kevmoo wrote:
> Did this land?
> 
>
https://github.com/dart-lang/sdk/commit/e6d92100bf2936907c891a17f934995c59017111
> 
> Weird to see it open.

This CL cannot be landed because it is against the stable branch. Bill did land
the equivalent code in the commit you quoted. I'll manually close this issue so
it is less confusing.

-Ivan

> Is there a description of the fix we can put in the changelog?
> https://github.com/dart-lang/sdk/issues/24675

[Ivan Posva, 2015-10-22 05:29:43]

Description was changed from

==========
Corrects cleanup on an error during Process startup

BUG=
==========

to

==========
Corrects cleanup on an error during Process startup

BUG=
==========