Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(631)

Unified Diff: runtime/bin/process_patch.dart

Issue 1420443002: Corrects cleanup on an error during Process startup (Closed) Base URL: git@github.com:dart-lang/sdk.git@stable
Patch Set: Don't use the process map at all, but leave the field Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/process_patch.dart
diff --git a/runtime/bin/process_patch.dart b/runtime/bin/process_patch.dart
index b6d40ee7a3eea18e8b8ee33fb6c0fd75f008734d..3126c26afc0f24822fa8fd222495793a18b8a49a 100644
--- a/runtime/bin/process_patch.dart
+++ b/runtime/bin/process_patch.dart
@@ -188,7 +188,6 @@ class _ProcessImpl extends _ProcessImplNativeWrapper with _ServiceObject
bool includeParentEnvironment,
bool runInShell,
ProcessStartMode mode) : super() {
- _processes[_serviceId] = this;
if (runInShell) {
arguments = _getShellArguments(path, arguments);
path = _getShellCommand();
@@ -439,7 +438,6 @@ class _ProcessImpl extends _ProcessImplNativeWrapper with _ServiceObject
_exitCode.complete(exitCode(exitDataBuffer));
// Kill stdin, helping hand if the user forgot to do it.
_stdin._sink.destroy();
- _processes.remove(_serviceId);
}
exitDataBuffer.setRange(
@@ -488,8 +486,6 @@ class _ProcessImpl extends _ProcessImplNativeWrapper with _ServiceObject
return encoding.decode(output);
}
- _processes.remove(_serviceId);
-
return new ProcessResult(
result[0],
result[1],
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698