Corrects cleanup on an error during Process startup

runtime/bin/process_patch.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 patch class _WindowsCodePageDecoder {
   /* patch */ static String _decodeBytes(List<int> bytes)
       native "SystemEncodingToString";
 }
 
 
@@ skipping 177 matching lines @@
                bool includeParentEnvironment,
                bool runInShell,
                ProcessStartMode mode) : super() {
     _processes[_serviceId] = this;
     if (runInShell) {
       arguments = _getShellArguments(path, arguments);
       path = _getShellCommand();
     }
 
     if (path is !String) {
       throw new ArgumentError("Path is not a String: $path");

[Ivan Posva, 2015/10/20 06:39:12]

Here?

[zra, 2015/10/20 16:03:26]

As discussed, we no longer populate the map.

     }
     _path = path;
 
     if (arguments is !List) {
       throw new ArgumentError("Arguments is not a List: $arguments");

[Ivan Posva, 2015/10/20 06:39:12]

And here?

     }
     int len = arguments.length;
     _arguments = new List<String>(len);
     for (int i = 0; i < len; i++) {
       var arg = arguments[i];
       if (arg is !String) {
         throw new ArgumentError("Non-string argument: $arg");

[Ivan Posva, 2015/10/20 06:39:12]

And many more places?

       }
       _arguments[i] = arguments[i];
       if (Platform.isWindows) {
         _arguments[i] = _windowsArgumentEscape(_arguments[i]);
       }
     }
 
     if (_workingDirectory != null && _workingDirectory is !String) {
       throw new ArgumentError(
           "WorkingDirectory is not a String: $_workingDirectory");
@@ skipping 181 matching lines @@
                        _mode == ProcessStartMode.DETACHED
                            ? null : _stdin._sink._nativeSocket,
                        _mode == ProcessStartMode.DETACHED
                            ? null : _stdout._stream._nativeSocket,
                        _mode == ProcessStartMode.DETACHED
                            ? null : _stderr._stream._nativeSocket,
                        _mode != ProcessStartMode.NORMAL
                            ? null : _exitHandler._nativeSocket,
                        status);
       if (!success) {
+        _processes.remove(_serviceId);
         completer.completeError(
             new ProcessException(_path,
                                  _arguments,
                                  status._errorMessage,
                                  status._errorCode));
         return;
       }
 
       _started = true;
 
@@ skipping 42 matching lines @@
                                 _arguments,
                                 _workingDirectory,
                                 _environment,
                                 ProcessStartMode.NORMAL.index,
                                 _stdin._sink._nativeSocket,
                                 _stdout._stream._nativeSocket,
                                 _stderr._stream._nativeSocket,
                                 _exitHandler._nativeSocket,
                                 status);
     if (!success) {
+      _processes.remove(_serviceId);
       throw new ProcessException(_path,
                                  _arguments,
                                  status._errorMessage,
                                  status._errorCode);
     }
 
     var result = _wait(
         _stdin._sink._nativeSocket,
         _stdout._stream._nativeSocket,
         _stderr._stream._nativeSocket,
@@ skipping 134 matching lines @@
       Encoding stderrEncoding) {
   var process = new _ProcessImpl(executable,
                                  arguments,
                                  workingDirectory,
                                  environment,
                                  includeParentEnvironment,
                                  runInShell,
                                  ProcessStartMode.NORMAL);
   return process._runAndWait(stdoutEncoding, stderrEncoding);
 }