Move more declarations from c/b/sb/sb_util.h to components.

1. Pull all code unrelated to chunking from chrome/browser/safe_browsing/safe_brwsing_util.h into components/safe_browsing_db.
2. All code that was formerly under the safe_browsing_util namespace is now under safe_browsing. That's the only namespace we plan to use going forward.
3. Chunking related code will stay in the old location and removed once we switch to PVER4.

The next CL in this series will move the structures/enums currently under the global namespace in safe_browsing_db_util.h into safe_browsing. I did not do that as part of this CL to keep it smaller and easier to review.

BUG=543161
Committed: https://crrev.com/154455e8186ad19a8b54ca23e344ade0d92c34cf
Cr-Commit-Position: refs/heads/master@{#357763}

[vakh (old account. dont use), 2015-10-23 01:35:47]

Description was changed from

==========
Move more declarations from c/b/sb/sb_util.h to components.

BUG=543161
==========

to

==========
1. Pull all code unrelated to chunking from
chrome/browser/safe_browsing/safe_brwsing_util.h into
components/safe_browsing_db.
2. All code that was formerly under the safe_browsing_util namespace is now
under safe_browsing. That's the only namespace we plan to use going forward.
3. Chunking related code will stay in the old location and removed once we
switch to PVER4.

The next CL in this series will move the structures/enums currently under the
global namespace in safe_browsing_db_util.h into safe_browsing. I did not do
that as part of this CL to keep it smaller and easier to review.

BUG=543161
==========

[vakh (old account. dont use), 2015-10-23 01:52:10]

vakh@google.com changed reviewers:
+ blundell@chromium.org, mattm@chromium.org, nparker@chromium.org,
thestig@chromium.org

[vakh (old account. dont use), 2015-10-23 01:52:11]

(optional) mattm@chromium.org: Please review changes in 
chrome/browser/safe_browsing/...
components/safe_browsing_db/...

nparker@chromium.org: Please review changes in 
chrome/browser/safe_browsing/...
components/safe_browsing_db/...

blundell@chromium.org: Please review changes in 
components/safe_browsing_db/...

thestig@chromium.org: Please review changes in 
chrome/chrome_tests_unit.gypi
chrome/browser/extensions/...

Base CL: https://codereview.chromium.org/1420123003/

[blundell, 2015-10-23 07:12:08]

You're better off having a //components/safe_browsing_db OWNER do the review of
//components/safe_browsing_db and then having me sign off on whatever top-level
//components changes there are (if any).

[Nathan Parker, 2015-10-26 19:43:19]

lgtm

How about naming these
  components/safe_browsing_db/util.*
rather than
  components/safe_browsing_db/safe_browsing_db_*

https://codereview.chromium.org/1420123003/diff/20001/components/safe_browsin...
File components/safe_browsing_db/safe_browsing_db_util.cc (right):

https://codereview.chromium.org/1420123003/diff/20001/components/safe_browsin...
components/safe_browsing_db/safe_browsing_db_util.cc:45: const char
kMalwareList[] = "goog-mobilemalware-shavar";
The OS_ANDROID section was removed (about a week ago, here:
https://codereview.chromium.org/1402783005).  You should make it match what's in
safe_browing_util.cc now.

[vakh (old account. dont use), 2015-10-27 22:35:34]

On 2015/10/26 19:43:19, nparker wrote:
> lgtm
> 
> How about naming these
>   components/safe_browsing_db/util.*
> rather than
>   components/safe_browsing_db/safe_browsing_db_*
> 
>
https://codereview.chromium.org/1420123003/diff/20001/components/safe_browsin...
> File components/safe_browsing_db/safe_browsing_db_util.cc (right):
> 
>
https://codereview.chromium.org/1420123003/diff/20001/components/safe_browsin...
> components/safe_browsing_db/safe_browsing_db_util.cc:45: const char
> kMalwareList[] = "goog-mobilemalware-shavar";
> The OS_ANDROID section was removed (about a week ago, here:
> https://codereview.chromium.org/1402783005).  You should make it match what's
in
> safe_browing_util.cc now.

Done.

[vakh (old account. dont use), 2015-11-03 01:50:21]

thestig@chromium.org: Please review changes in:
chrome/browser/extensions/fake_safe_browsing_database_manager.cc
chrome/browser/prerender/prerender_browsertest.cc


blundell@chromium.org: Please review changes in
components/safe_browsing_db.gypi

Thanks!

[Lei Zhang, 2015-11-03 01:52:01]

On 2015/11/03 01:50:21, Varun Khaneja wrote:
> mailto:thestig@chromium.org: Please review changes in:
> chrome/browser/extensions/fake_safe_browsing_database_manager.cc
> chrome/browser/prerender/prerender_browsertest.cc

lgtm

[blundell, 2015-11-03 08:31:50]

//components top-level lgtm

You can add per-file owners for the gypi file in //components/OWNERS.

[vakh (old account. dont use), 2015-11-03 22:24:40]

The CQ bit was checked by vakh@google.com

[vakh (old account. dont use), 2015-11-03 22:24:40]

The patchset sent to the CQ was uploaded after l-g-t-m from nparker@chromium.org
Link to the patchset: https://codereview.chromium.org/1420123003/#ps160001
(title: "Minor: Replace safe_browsing_util:: with safe_browsing:: and use
safe_browsing:: namespace prefix")

[commit-bot: I haz the power, 2015-11-03 22:25:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1420123003/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1420123003/160001

[commit-bot: I haz the power, 2015-11-03 22:48:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-03 22:48:25]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[vakh (old account. dont use), 2015-11-03 22:52:46]

On 2015/11/03 22:48:25, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

@blundell, that's a good idea. I'll do that as a separate tiny CL.

mattm@, please review to allow the dependency on +net

[mattm, 2015-11-04 03:23:31]

DEPS lgtm

[vakh (old account. dont use), 2015-11-04 04:19:42]

The CQ bit was checked by vakh@google.com

[commit-bot: I haz the power, 2015-11-04 04:20:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1420123003/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1420123003/160001

[commit-bot: I haz the power, 2015-11-04 05:46:39]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2015-11-04 05:47:41]

Patchset 9 (id:??) landed as
https://crrev.com/154455e8186ad19a8b54ca23e344ade0d92c34cf
Cr-Commit-Position: refs/heads/master@{#357763}

[binjin, 2015-11-04 12:13:51]

A revert of this CL (patchset #9 id:160001) has been created in
https://codereview.chromium.org/1410343012/ by binjin@chromium.org.

The reason for reverting is: Suspected to break the win compile:
FAILED: ninja -t msvc -e environment.x64 -- E:\b\build\goma/gomacc.exe
"E:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64/cl.exe" /nologo
/showIncludes /FC @obj/components/safe_browsing_db/util/util.obj.rsp /c
../../components/safe_browsing_db/util.cc
/Foobj/components/safe_browsing_db/util/util.obj
/Fdobj/components/safe_browsing_db/util_cc.pdb
e:\b\build\slave\win_x64_gn__dbg_\build\src\components\safe_browsing_db\util.cc(225)
:error C2220: warning treated as error - no 'object' file generated
.

[blundell, 2015-11-04 12:21:09]

On 2015/11/04 12:13:51, binjin wrote:
> A revert of this CL (patchset #9 id:160001) has been created in
> https://codereview.chromium.org/1410343012/ by mailto:binjin@chromium.org.
> 
> The reason for reverting is: Suspected to break the win compile:
> FAILED: ninja -t msvc -e environment.x64 -- E:\b\build\goma/gomacc.exe
> "E:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64/cl.exe" /nologo
> /showIncludes /FC @obj/components/safe_browsing_db/util/util.obj.rsp /c
> ../../components/safe_browsing_db/util.cc
> /Foobj/components/safe_browsing_db/util/util.obj
> /Fdobj/components/safe_browsing_db/util_cc.pdb
>
e:\b\build\slave\win_x64_gn__dbg_\build\src\components\safe_browsing_db\util.cc(225)
> :error C2220: warning treated as error - no 'object' file generated
> .

Please in general add a link to the failing bot run in the CL description for
the revert. Can you provide that link here?