Move prefix_set and parts of safe_browsing_util into a new component safe_browsing_db.

[This CL = CL 1399843003 + disabling E4267 for MSVS (in safe_browsing_db.gypi)]

Move prefix_set and parts of safe_browsing_util into a new component
safe_browsing_db.
This component will hold the new implementation for the
next version (pver4) of the update protocol and DB.

BUG=543161
Committed: https://crrev.com/9d588802e87e1776c0e55f7c0e8b21dc5acbf1bd
Cr-Commit-Position: refs/heads/master@{#356943}

[vakh (old account. dont use), 2015-10-22 23:02:05]

Description was changed from

==========
[This CL = CL 1399843003 + disabling E4267 for MSVS (in safe_browsing_db.gypi)]
Move prefix_set and parts of safe_browsing_util into a new component
safe_browsing_db.

This component will hold the new implementation for the
next version (pver4) of the update protocol and DB.

BUG=543161
==========

to

==========
[This CL = CL 1399843003 + disabling E4267 for MSVS (in safe_browsing_db.gypi)]

Move prefix_set and parts of safe_browsing_util into a new component
safe_browsing_db.
This component will hold the new implementation for the
next version (pver4) of the update protocol and DB.

BUG=543161
==========

[vakh (old account. dont use), 2015-10-22 23:02:05]

vakh@google.com changed reviewers:
+ mattm@chromium.org, nparker@chromium.org, rsleevi@chromium.org

[Nathan Parker, 2015-10-22 23:06:24]

lgtm

You'll need thestig@ and bludnell@ from the original CL.

[vakh (old account. dont use), 2015-10-22 23:21:43]

vakh@google.com changed reviewers:
+ blundell@chromium.org, thestig@chromium.org

[Ryan Sleevi, 2015-10-22 23:22:16]

lgtm

[blundell, 2015-10-23 07:10:29]

A good way to handle a reland in the code review system is:

(1) Upload the original CL (e.g., create a new branch, revert the revert of your
CL, and then immediately upload).
(2) Make your fixes.
(3) Upload your fixes as PS2.
(4) Send out for review, noting that PS1 is the original CL and PS2 is your
patches for <whatever bustage caused the original CL to be reverted>.

That way reviewers can actually see and review the diff.

https://codereview.chromium.org/1415923004/diff/1/components/safe_browsing_db...
File components/safe_browsing_db/BUILD.gn (right):

https://codereview.chromium.org/1415923004/diff/1/components/safe_browsing_db...
components/safe_browsing_db/BUILD.gn:1: # Copyright 2015 The Chromium Authors.
All rights reserved.
You need to suppress the warning in this file as well as in
safe_browsing_db.gypi.

https://codereview.chromium.org/1415923004/diff/1/components/safe_browsing_db...
components/safe_browsing_db/BUILD.gn:22: source_set("safe_browsing_db_util") {
This is really a comment for the original CL, but: why a different structure
between this BUILD.gn file and safe_browsing_db.gypi?

[vakh (old account. dont use), 2015-10-27 19:48:55]

On 2015/10/23 07:10:29, blundell wrote:
> A good way to handle a reland in the code review system is:
> 
> (1) Upload the original CL (e.g., create a new branch, revert the revert of
your
> CL, and then immediately upload).
> (2) Make your fixes.
> (3) Upload your fixes as PS2.
> (4) Send out for review, noting that PS1 is the original CL and PS2 is your
> patches for <whatever bustage caused the original CL to be reverted>.
> 
> That way reviewers can actually see and review the diff.
Thanks, I agree it is better to do it that way. I'll do that in future.

> 
>
https://codereview.chromium.org/1415923004/diff/1/components/safe_browsing_db...
> File components/safe_browsing_db/BUILD.gn (right):
> 
>
https://codereview.chromium.org/1415923004/diff/1/components/safe_browsing_db...
> components/safe_browsing_db/BUILD.gn:1: # Copyright 2015 The Chromium Authors.
> All rights reserved.
> You need to suppress the warning in this file as well as in
> safe_browsing_db.gypi.
> 
>
https://codereview.chromium.org/1415923004/diff/1/components/safe_browsing_db...
> components/safe_browsing_db/BUILD.gn:22: source_set("safe_browsing_db_util") {
> This is really a comment for the original CL, but: why a different structure
> between this BUILD.gn file and safe_browsing_db.gypi?

[vakh (old account. dont use), 2015-10-27 19:49:04]

https://codereview.chromium.org/1415923004/diff/1/components/safe_browsing_db...
File components/safe_browsing_db/BUILD.gn (right):

https://codereview.chromium.org/1415923004/diff/1/components/safe_browsing_db...
components/safe_browsing_db/BUILD.gn:1: # Copyright 2015 The Chromium Authors.
All rights reserved.
On 2015/10/23 07:10:29, blundell wrote:
> You need to suppress the warning in this file as well as in
> safe_browsing_db.gypi.

Done.

https://codereview.chromium.org/1415923004/diff/1/components/safe_browsing_db...
components/safe_browsing_db/BUILD.gn:22: source_set("safe_browsing_db_util") {
On 2015/10/23 07:10:29, blundell wrote:
> This is really a comment for the original CL, but: why a different structure
> between this BUILD.gn file and safe_browsing_db.gypi?

2 reasons:
1. I am more familiar with BUILD files so I could give it a better structure.
2. The BUILD.gn file is common between product code and tests so I can create
individual targets that both group("safe_browsing_db") and
source_set("unit_tests") can depend on. For .gyp, we have different files for
code and test so creating components for safe_browsing_util and prefix_set
didn't seem that useful.

[blundell, 2015-10-28 06:20:55]

lgtm

[vakh (old account. dont use), 2015-10-29 07:18:58]

@thestig, could you please lgtm the changes under:
chrome/browser/...
chrome/test/...

Thanks!

[Lei Zhang, 2015-10-29 15:04:41]

On 2015/10/29 07:18:58, Varun Khaneja wrote:
> @thestig, could you please lgtm the changes under:
> chrome/browser/...
> chrome/test/...
> 
> Thanks!

lgtm

[vakh (old account. dont use), 2015-10-29 19:55:27]

The CQ bit was checked by vakh@google.com

[vakh (old account. dont use), 2015-10-29 19:55:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
nparker@chromium.org, rsleevi@chromium.org
Link to the patchset: https://codereview.chromium.org/1415923004/#ps20001
(title: "Suppress the 4267 warning in BUILD.gn")

[commit-bot: I haz the power, 2015-10-29 19:55:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1415923004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1415923004/20001

[commit-bot: I haz the power, 2015-10-29 21:04:15]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-10-29 21:04:53]

Patchset 2 (id:??) landed as
https://crrev.com/9d588802e87e1776c0e55f7c0e8b21dc5acbf1bd
Cr-Commit-Position: refs/heads/master@{#356943}