Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(959)

Issue 1402783005: Remove safe_browsing=2 functionality, replace with =3 mode. (Closed)

Created:
5 years, 2 months ago by Nathan Parker
Modified:
5 years, 2 months ago
CC:
chromium-reviews, asanka, gsennton, vakh (old account. dont use)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove safe_browsing=2 functionality, replace with =3 mode. Remove refs to SAFE_BROWSING_SERVICE, MOBILE_SAFE_BROWSING, and removes the half-dead code that supported FULL_SAFE_BROWSING on Android. This affects no change in functionality. BUG=542795 Committed: https://crrev.com/00a64f18a8e513fce349820231e10786c2709828 Cr-Commit-Position: refs/heads/master@{#354535}

Patch Set 1 #

Patch Set 2 : fix BUILD.gn #

Patch Set 3 : Remove SAFE_BROWSING_SERVICE defs #

Patch Set 4 : Remove support for FULL_SAFE_BROWSING on Android #

Patch Set 5 : fix up histograms #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -162 lines) Patch
M build/common.gypi View 1 2 4 chunks +4 lines, -18 lines 0 comments Download
M build/config/BUILD.gn View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M build/config/features.gni View 1 chunk +5 lines, -6 lines 0 comments Download
M chrome/browser/BUILD.gn View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/browser_process_impl.cc View 1 2 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_remover.cc View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_remover_unittest.cc View 1 2 4 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/download/chrome_download_manager_delegate.cc View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_io_data.cc View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_impl_io_data.cc View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/local_database_manager.cc View 1 2 3 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/safe_browsing/protocol_manager.h View 1 2 3 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/safe_browsing/protocol_manager.cc View 1 2 3 4 chunks +0 lines, -24 lines 0 comments Download
M chrome/browser/safe_browsing/protocol_manager_helper.h View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/safe_browsing/protocol_manager_helper.cc View 1 2 3 1 chunk +2 lines, -8 lines 0 comments Download
M chrome/browser/safe_browsing/protocol_manager_unittest.cc View 1 2 3 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_database.cc View 1 2 3 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_service.cc View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_test.cc View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_util.cc View 1 2 3 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/chrome_renderer.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/common_message_generator.h View 1 2 2 chunks +1 line, -3 lines 0 comments Download
M chrome/common/safe_browsing/safebrowsing_messages.h View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/renderer/BUILD.gn View 1 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/test/BUILD.gn View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 4 3 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (3 generated)
Nathan Parker
5 years, 2 months ago (2015-10-15 00:37:42 UTC) #2
scottmg
build/ lgtm
5 years, 2 months ago (2015-10-15 16:29:44 UTC) #3
mattm
lgtm
5 years, 2 months ago (2015-10-16 02:38:49 UTC) #4
Lei Zhang
lgtm You still need a histograms.xml reviewer.
5 years, 2 months ago (2015-10-16 02:47:21 UTC) #5
Nathan Parker
asvitkine@chromium.org: Please review changes in histograms.xml jorgelo@chromium.org: Please review changes in chrome/common/safe_browsing/safebrowsing_messages.h Thanks!
5 years, 2 months ago (2015-10-16 02:52:21 UTC) #7
Nathan Parker
asvitkine@chromium.org: Please review changes in histograms.xml jorgelo@chromium.org: Please review changes in chrome/common/safe_browsing/safebrowsing_messages.h Thanks!
5 years, 2 months ago (2015-10-16 02:52:23 UTC) #8
Jorge Lucangeli Obes
On 2015/10/16 02:52:23, nparker wrote: > mailto:asvitkine@chromium.org: Please review changes in > histograms.xml > > ...
5 years, 2 months ago (2015-10-16 04:30:49 UTC) #9
Alexei Svitkine (slow)
lgtm
5 years, 2 months ago (2015-10-16 15:05:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1402783005/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1402783005/80001
5 years, 2 months ago (2015-10-16 15:42:39 UTC) #12
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 2 months ago (2015-10-16 17:34:41 UTC) #13
commit-bot: I haz the power
5 years, 2 months ago (2015-10-16 17:35:40 UTC) #14
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/00a64f18a8e513fce349820231e10786c2709828
Cr-Commit-Position: refs/heads/master@{#354535}

Powered by Google App Engine
This is Rietveld 408576698