Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 14200034: Revert 194578 "Add ash SessionStateDelegate" (Closed)

Created:
7 years, 8 months ago by gavinp
Modified:
7 years, 8 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 194578 "Add ash SessionStateDelegate" > Add ash SessionStateDelegate > > This CL refactors the ShellDelegate by adding a SessionStateDelegate to > which methods dealing with the session state can be moved. This cleans up > the huge ShellDelegate interface and paves the way for further Chrome OS > multiprofile work which will need to add several new methods related to > the session state. > > This CL is only the first step. Several other methods should also move to > SessionStateDelegate but I do not want to overburden a single CL. > > BUG=None > TEST=Manual and browser/unit tests > > TBR=sky (for c/b/idle_chromeos.cc and c/chrome_browser_ui.gypi) > > Review URL: https://codereview.chromium.org/14295008 TBR=bartfab@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194589

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+344 lines, -553 lines) Patch
M trunk/src/ash/accelerators/accelerator_controller.cc View 3 chunks +7 lines, -4 lines 0 comments Download
M trunk/src/ash/accelerators/nested_dispatcher_controller_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/ash/ash.gyp View 4 chunks +0 lines, -7 lines 0 comments Download
M trunk/src/ash/desktop_background/desktop_background_view.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M trunk/src/ash/root_window_controller.cc View 2 chunks +1 line, -2 lines 0 comments Download
M trunk/src/ash/root_window_controller_unittest.cc View 5 chunks +7 lines, -7 lines 0 comments Download
D trunk/src/ash/session_state_delegate.h View 1 chunk +0 lines, -41 lines 0 comments Download
D trunk/src/ash/session_state_delegate_stub.h View 1 chunk +0 lines, -36 lines 0 comments Download
D trunk/src/ash/session_state_delegate_stub.cc View 1 chunk +0 lines, -45 lines 0 comments Download
M trunk/src/ash/shelf/shelf_layout_manager.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M trunk/src/ash/shelf/shelf_layout_manager_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/ash/shelf/shelf_widget.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M trunk/src/ash/shell.h View 4 chunks +7 lines, -6 lines 0 comments Download
M trunk/src/ash/shell.cc View 4 chunks +11 lines, -6 lines 0 comments Download
M trunk/src/ash/shell/app_list.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/ash/shell/lock_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/ash/shell/shell_delegate_impl.h View 3 chunks +8 lines, -1 line 0 comments Download
M trunk/src/ash/shell/shell_delegate_impl.cc View 5 chunks +32 lines, -6 lines 0 comments Download
M trunk/src/ash/shell/window_type_launcher.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/ash/shell_delegate.h View 4 chunks +22 lines, -4 lines 0 comments Download
M trunk/src/ash/shell_unittest.cc View 3 chunks +6 lines, -8 lines 0 comments Download
M trunk/src/ash/system/date/tray_date.cc View 2 chunks +1 line, -2 lines 0 comments Download
M trunk/src/ash/system/tray/test_system_tray_delegate.cc View 2 chunks +3 lines, -6 lines 0 comments Download
MM trunk/src/ash/test/ash_test_base.cc View 2 chunks +3 lines, -7 lines 0 comments Download
D trunk/src/ash/test/test_session_state_delegate.h View 1 chunk +0 lines, -67 lines 0 comments Download
D trunk/src/ash/test/test_session_state_delegate.cc View 1 chunk +0 lines, -63 lines 0 comments Download
M trunk/src/ash/test/test_shell_delegate.h View 4 chunks +32 lines, -6 lines 0 comments Download
M trunk/src/ash/test/test_shell_delegate.cc View 5 chunks +50 lines, -15 lines 0 comments Download
M trunk/src/ash/wm/event_client_impl.cc View 2 chunks +1 line, -3 lines 0 comments Download
M trunk/src/ash/wm/gestures/shelf_gesture_handler.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/ash/wm/power_button_controller.cc View 4 chunks +8 lines, -15 lines 0 comments Download
M trunk/src/ash/wm/power_button_controller_unittest.cc View 11 chunks +8 lines, -11 lines 0 comments Download
M trunk/src/ash/wm/session_state_controller_impl2_unittest.cc View 7 chunks +4 lines, -7 lines 0 comments Download
M trunk/src/ash/wm/stacking_controller.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M trunk/src/ash/wm/system_modal_container_layout_manager.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M trunk/src/ash/wm/system_modal_container_layout_manager_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M trunk/src/ash/wm/window_cycle_controller.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M trunk/src/ash/wm/window_cycle_controller_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M trunk/src/ash/wm/workspace/workspace_cycler.cc View 2 chunks +1 line, -2 lines 0 comments Download
M trunk/src/ash/wm/workspace/workspace_layout_manager.cc View 2 chunks +1 line, -2 lines 0 comments Download
M trunk/src/chrome/browser/chromeos/dbus/printer_service_provider.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M trunk/src/chrome/browser/idle_chromeos.cc View 2 chunks +1 line, -2 lines 0 comments Download
M trunk/src/chrome/browser/ui/ash/chrome_shell_delegate.h View 2 chunks +7 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/ui/ash/chrome_shell_delegate.cc View 4 chunks +5 lines, -6 lines 0 comments Download
M trunk/src/chrome/browser/ui/ash/chrome_shell_delegate_chromeos.cc View 4 chunks +48 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/ui/ash/chrome_shell_delegate_views.cc View 1 chunk +24 lines, -0 lines 0 comments Download
D trunk/src/chrome/browser/ui/ash/session_state_delegate.h View 1 chunk +0 lines, -29 lines 0 comments Download
D trunk/src/chrome/browser/ui/ash/session_state_delegate_chromeos.cc View 1 chunk +0 lines, -49 lines 0 comments Download
D trunk/src/chrome/browser/ui/ash/session_state_delegate_views.cc View 1 chunk +0 lines, -33 lines 0 comments Download
M trunk/src/chrome/chrome_browser_ui.gypi View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
gavinp
7 years, 8 months ago (2013-04-17 14:47:31 UTC) #1
gavinp
7 years, 8 months ago (2013-04-17 14:47:51 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r194589.

Powered by Google App Engine
This is Rietveld 408576698