Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(569)

Issue 1419633002: Conditionally include ui_base dependency in version_info (Closed)

Created:
5 years, 2 months ago by joleksy
Modified:
5 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Conditionally include ui_base dependency in version_info Defining use_unofficial_version_number will allow controlling the inclusion of ui_base dependency, indepentently of used branding. BUG= Committed: https://crrev.com/0495daebb14f34371cc744455dec55dcdf35b349 Cr-Commit-Position: refs/heads/master@{#355292}

Patch Set 1 #

Patch Set 2 : gn fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -6 lines) Patch
M components/version_info.gypi View 3 chunks +15 lines, -1 line 0 comments Download
M components/version_info/BUILD.gn View 1 2 chunks +10 lines, -3 lines 0 comments Download
M components/version_info/version_info.cc View 3 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
joleksy
On 2015/10/20 11:18:38, joleksy wrote: > mailto:joleksy@opera.com changed reviewers: > + mailto:jochen@chromium.org @reviewer: does it ...
5 years, 2 months ago (2015-10-20 11:19:05 UTC) #3
jochen (gone - plz use gerrit)
lgtm
5 years, 2 months ago (2015-10-21 13:34:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419633002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419633002/20001
5 years, 2 months ago (2015-10-21 13:37:22 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-21 14:37:10 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-21 14:38:23 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0495daebb14f34371cc744455dec55dcdf35b349
Cr-Commit-Position: refs/heads/master@{#355292}

Powered by Google App Engine
This is Rietveld 408576698