Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Unified Diff: components/version_info/version_info.cc

Issue 1419633002: Conditionally include ui_base dependency in version_info (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: gn fix Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/version_info/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/version_info/version_info.cc
diff --git a/components/version_info/version_info.cc b/components/version_info/version_info.cc
index 00546f7918415ce13076f0c68d1aa405ddf1b7ae..a6c39164e0e364422165d865aace2071e67c862d 100644
--- a/components/version_info/version_info.cc
+++ b/components/version_info/version_info.cc
@@ -7,7 +7,10 @@
#include "build/build_config.h"
#include "components/version_info/version_info_values.h"
#include "grit/components_strings.h"
+
+#if defined(USE_UNOFFICIAL_VERSION_NUMBER)
#include "ui/base/l10n/l10n_util.h"
+#endif // USE_UNOFFICIAL_VERSION_NUMBER
namespace version_info {
@@ -83,7 +86,7 @@ std::string GetChannelString(Channel channel) {
std::string GetVersionStringWithModifier(const std::string& modifier) {
std::string current_version;
current_version += GetVersionNumber();
-#if !defined(GOOGLE_CHROME_BUILD)
+#if defined(USE_UNOFFICIAL_VERSION_NUMBER)
current_version += " (";
current_version += l10n_util::GetStringUTF8(IDS_VERSION_UI_UNOFFICIAL);
current_version += " ";
@@ -91,7 +94,7 @@ std::string GetVersionStringWithModifier(const std::string& modifier) {
current_version += " ";
current_version += GetOSType();
current_version += ")";
-#endif
+#endif // USE_UNOFFICIAL_VERSION_NUMBER
if (!modifier.empty())
current_version += " " + modifier;
return current_version;
« no previous file with comments | « components/version_info/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698