Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: components/version_info/BUILD.gn

Issue 1419633002: Conditionally include ui_base dependency in version_info (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: gn fix Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/version_info.gypi ('k') | components/version_info/version_info.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/version_info/BUILD.gn
diff --git a/components/version_info/BUILD.gn b/components/version_info/BUILD.gn
index c28d69951f38956f4fc51e5c3d4a7146a4f7aef7..0ee4a4ab4e0f9c23964c2128eb409990061091bd 100644
--- a/components/version_info/BUILD.gn
+++ b/components/version_info/BUILD.gn
@@ -2,14 +2,17 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
+import("//build/config/chrome_build.gni")
import("//chrome/version.gni")
-if (is_ios) {
- declare_args() {
+declare_args() {
+ if (is_ios) {
# Path to the file used to override the version PATH level on iOS.
# Default to ios/build/util/VERSION.
ios_extra_version_path = "//ios/build/util/VERSION"
}
+
+ use_unofficial_version_number = !is_chrome_branded
}
source_set("version_info") {
@@ -21,9 +24,13 @@ source_set("version_info") {
deps = [
"//base",
"//components/strings",
- "//ui/base",
]
+ if (use_unofficial_version_number) {
+ defines = [ "USE_UNOFFICIAL_VERSION_NUMBER" ]
+ deps += [ "//ui/base" ]
+ }
+
public_deps = [
":generate_version_info",
]
« no previous file with comments | « components/version_info.gypi ('k') | components/version_info/version_info.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698