Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(818)

Unified Diff: components/version_info.gypi

Issue 1419633002: Conditionally include ui_base dependency in version_info (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: gn fix Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/version_info/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/version_info.gypi
diff --git a/components/version_info.gypi b/components/version_info.gypi
index 15159c45ee68555d2e6874bab8aa09cf3b884155..42bafbece5569ef052eb27edc1f9128f1dd2e933 100644
--- a/components/version_info.gypi
+++ b/components/version_info.gypi
@@ -10,6 +10,13 @@
# of a file with the corresponding value overrides. If present it will
# be loaded after all other input files.
'extra_version_name': '',
+ 'conditions': [
+ ['branding == "Chrome"', {
+ 'use_unofficial_version_number%': 0,
+ }, {
+ 'use_unofficial_version_number%': 1,
+ }],
+ ],
},
'targets': [
{
@@ -21,7 +28,6 @@
],
'dependencies': [
'../base/base.gyp:base',
- '../ui/base/ui_base.gyp:ui_base',
'components_strings.gyp:components_strings',
'generate_version_info',
],
@@ -29,6 +35,14 @@
'version_info/version_info.cc',
'version_info/version_info.h',
],
+ 'conditions': [
+ ['use_unofficial_version_number==1', {
+ 'dependencies': [
+ '../ui/base/ui_base.gyp:ui_base',
+ ],
+ 'defines': ['USE_UNOFFICIAL_VERSION_NUMBER'],
+ }],
+ ],
'export_dependent_settings': [
'generate_version_info',
],
« no previous file with comments | « no previous file | components/version_info/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698