[Cronet] Switch from InstrumentationTest to junit

[Cronet] Switch from InstrumentationTest to junit

Instrumentation tests are meant for testing apps, where as junit tests
are better for unit testing, which is what the cronet tests do.
This change gets rid of the restriction of setting up the tests via
an Intent.  It removes a fair bit of code and paves the way for
removing more, including JSON serializing of CronetEngine.Builder.

I think this makes testing faster...because I ran into two race
conditions in tests that I also fixed:
1. Starting the CronetTestFramework with a URL did not wait for the
   request to finish.
2. NetworkChangeNotifier initialization test did not wait for the
   NetworkChangeNotifier to actually initialize.

For now the test continues to be launched as an instrumentation test
because this ensures lighttpd is launched, which isn't the case for
junit tests.  All tests run and pass being launched as an
instrumentation test.

BUG=544976
Committed: https://crrev.com/373bed9bc93f00af4244808cff41c355de268ed7
Cr-Commit-Position: refs/heads/master@{#355770}

[pauljensen, 2015-10-21 23:45:33]

Description was changed from

==========
[Cronet] Switch from InstrumentationTest to junit

Instrumentation tests are meant for testing apps, where as junit tests
are better for unit testing, which is what the cronet tests do.
This change gets rid of the restriction of setting up the tests via
an Intent.  It removes a fair bit of code and paves the way for
removing more, including JSON serializing of CronetEngine.Builder.

BUG=544976
==========

to

==========
[Cronet] Switch from InstrumentationTest to junit

Instrumentation tests are meant for testing apps, where as junit tests
are better for unit testing, which is what the cronet tests do.
This change gets rid of the restriction of setting up the tests via
an Intent.  It removes a fair bit of code and paves the way for
removing more, including JSON serializing of CronetEngine.Builder.

I think this makes testing faster...because I ran into two race
conditions in tests that I also fixed:
1. Starting the CronetTestFramework with a URL did not wait for the
   request to finish.
2. NetworkChangeNotifier initialization test did not wait for the
   NetworkChangeNotifier to actually initialize.

For now the test continues to be launched as an instrumentation test
because this ensures lighttpd is launched, which isn't the case for
junit tests.  All tests run and pass being launched as an
instrumentation test.

BUG=544976
==========

[pauljensen, 2015-10-22 00:37:03]

pauljensen@chromium.org changed reviewers:
+ xunjieli@chromium.org

[pauljensen, 2015-10-22 00:37:03]

Helen, PTAL.

[xunjieli, 2015-10-22 18:41:05]

On 2015/10/22 00:37:03, pauljensen wrote:
> Helen, PTAL.

This is great! I am happy as long as tests pass. LGTM with a few nits.

[xunjieli, 2015-10-22 18:41:24]

https://codereview.chromium.org/1417973002/diff/80001/components/cronet/andro...
File
components/cronet/android/test/javatests/src/org/chromium/net/CronetTestBase.java
(right):

https://codereview.chromium.org/1417973002/diff/80001/components/cronet/andro...
components/cronet/android/test/javatests/src/org/chromium/net/CronetTestBase.java:23:
* Starts the CronetTest activity.
nit: outdated comment containing the word "activity".

https://codereview.chromium.org/1417973002/diff/80001/components/cronet/andro...
components/cronet/android/test/javatests/src/org/chromium/net/CronetTestBase.java:38:
* Starts the CronetTest activity appending the provided command line
nit: outdated comment containing the word "activity".

https://codereview.chromium.org/1417973002/diff/80001/components/cronet/andro...
components/cronet/android/test/javatests/src/org/chromium/net/CronetTestBase.java:47:
// Helper method to tell the activity to skip factory init in onCreate().
nit: outdated comment containing the word "activity".

https://codereview.chromium.org/1417973002/diff/80001/components/cronet/andro...
File
components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlTest.java
(right):

https://codereview.chromium.org/1417973002/diff/80001/components/cronet/andro...
components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlTest.java:17:
* Example test that just starts the cronet sample.
optional nit: If you don't mind, maybe you could update the comment here?
Maybe also mention the fact that it is testing a deprecated API.

https://codereview.chromium.org/1417973002/diff/80001/components/cronet/andro...
File
components/cronet/android/test/javatests/src/org/chromium/net/NetworkChangeNotifierTest.java
(right):

https://codereview.chromium.org/1417973002/diff/80001/components/cronet/andro...
components/cronet/android/test/javatests/src/org/chromium/net/NetworkChangeNotifierTest.java:27:
NetworkChangeNotifierTestUtil.flushUiThreadTaskQueue();
Ah, I see. Thanks for fixing this!

https://codereview.chromium.org/1417973002/diff/80001/components/cronet/andro...
File
components/cronet/android/test/src/org/chromium/net/CronetTestFramework.java
(right):

https://codereview.chromium.org/1417973002/diff/80001/components/cronet/andro...
components/cronet/android/test/src/org/chromium/net/CronetTestFramework.java:29:
* Activity for managing the Cronet Test.
nit: Outdated comment containing the word "activity".

https://codereview.chromium.org/1417973002/diff/80001/components/cronet/andro...
components/cronet/android/test/src/org/chromium/net/CronetTestFramework.java:70:
private final Context mContext;
nit: Private fields should go after public ones.

https://codereview.chromium.org/1417973002/diff/80001/net/test/android/javate...
File
net/test/android/javatests/src/org/chromium/net/test/util/NetworkChangeNotifierTestUtil.java
(right):

https://codereview.chromium.org/1417973002/diff/80001/net/test/android/javate...
net/test/android/javatests/src/org/chromium/net/test/util/NetworkChangeNotifierTestUtil.java:16:
* Flush UI thread task queue.
nit: s/Flush/Flushes.

[pauljensen, 2015-10-23 11:35:50]

https://codereview.chromium.org/1417973002/diff/80001/components/cronet/andro...
File
components/cronet/android/test/javatests/src/org/chromium/net/CronetTestBase.java
(right):

https://codereview.chromium.org/1417973002/diff/80001/components/cronet/andro...
components/cronet/android/test/javatests/src/org/chromium/net/CronetTestBase.java:23:
* Starts the CronetTest activity.
On 2015/10/22 18:41:24, xunjieli wrote:
> nit: outdated comment containing the word "activity".

Done.

https://codereview.chromium.org/1417973002/diff/80001/components/cronet/andro...
components/cronet/android/test/javatests/src/org/chromium/net/CronetTestBase.java:38:
* Starts the CronetTest activity appending the provided command line
On 2015/10/22 18:41:24, xunjieli wrote:
> nit: outdated comment containing the word "activity".

Done.

https://codereview.chromium.org/1417973002/diff/80001/components/cronet/andro...
components/cronet/android/test/javatests/src/org/chromium/net/CronetTestBase.java:47:
// Helper method to tell the activity to skip factory init in onCreate().
On 2015/10/22 18:41:24, xunjieli wrote:
> nit: outdated comment containing the word "activity".

Done.

https://codereview.chromium.org/1417973002/diff/80001/components/cronet/andro...
File
components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlTest.java
(right):

https://codereview.chromium.org/1417973002/diff/80001/components/cronet/andro...
components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlTest.java:17:
* Example test that just starts the cronet sample.
On 2015/10/22 18:41:24, xunjieli wrote:
> optional nit: If you don't mind, maybe you could update the comment here?
> Maybe also mention the fact that it is testing a deprecated API.

Done.

https://codereview.chromium.org/1417973002/diff/80001/components/cronet/andro...
File
components/cronet/android/test/javatests/src/org/chromium/net/NetworkChangeNotifierTest.java
(right):

https://codereview.chromium.org/1417973002/diff/80001/components/cronet/andro...
components/cronet/android/test/javatests/src/org/chromium/net/NetworkChangeNotifierTest.java:27:
NetworkChangeNotifierTestUtil.flushUiThreadTaskQueue();
On 2015/10/22 18:41:24, xunjieli wrote:
> Ah, I see. Thanks for fixing this!

Acknowledged.

https://codereview.chromium.org/1417973002/diff/80001/components/cronet/andro...
File
components/cronet/android/test/src/org/chromium/net/CronetTestFramework.java
(right):

https://codereview.chromium.org/1417973002/diff/80001/components/cronet/andro...
components/cronet/android/test/src/org/chromium/net/CronetTestFramework.java:29:
* Activity for managing the Cronet Test.
On 2015/10/22 18:41:24, xunjieli wrote:
> nit: Outdated comment containing the word "activity".

Done.

https://codereview.chromium.org/1417973002/diff/80001/components/cronet/andro...
components/cronet/android/test/src/org/chromium/net/CronetTestFramework.java:70:
private final Context mContext;
On 2015/10/22 18:41:24, xunjieli wrote:
> nit: Private fields should go after public ones.

Done.

https://codereview.chromium.org/1417973002/diff/80001/net/test/android/javate...
File
net/test/android/javatests/src/org/chromium/net/test/util/NetworkChangeNotifierTestUtil.java
(right):

https://codereview.chromium.org/1417973002/diff/80001/net/test/android/javate...
net/test/android/javatests/src/org/chromium/net/test/util/NetworkChangeNotifierTestUtil.java:16:
* Flush UI thread task queue.
On 2015/10/22 18:41:24, xunjieli wrote:
> nit: s/Flush/Flushes.

Done.

[pauljensen, 2015-10-23 12:16:10]

The CQ bit was checked by pauljensen@chromium.org

[pauljensen, 2015-10-23 12:16:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
xunjieli@chromium.org
Link to the patchset: https://codereview.chromium.org/1417973002/#ps100001
(title: "address Helen's comments")

[commit-bot: I haz the power, 2015-10-23 12:16:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1417973002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1417973002/100001

[commit-bot: I haz the power, 2015-10-23 13:18:50]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-10-23 13:19:48]

Patchset 6 (id:??) landed as
https://crrev.com/373bed9bc93f00af4244808cff41c355de268ed7
Cr-Commit-Position: refs/heads/master@{#355770}