Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetHttpURLStreamHandlerTest.java

Issue 1417973002: [Cronet] Switch from InstrumentationTest to junit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address Helen's comments Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetHttpURLStreamHandlerTest.java
diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetHttpURLStreamHandlerTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetHttpURLStreamHandlerTest.java
index 19b81d503b9313bf176b23fd6335533e4688a6d4..cb71eea55a7941a621b8c4f9a8b84ebf3c8459a8 100644
--- a/components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetHttpURLStreamHandlerTest.java
+++ b/components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetHttpURLStreamHandlerTest.java
@@ -7,8 +7,8 @@ package org.chromium.net.urlconnection;
import android.test.suitebuilder.annotation.SmallTest;
import org.chromium.base.test.util.Feature;
-import org.chromium.net.CronetTestActivity;
import org.chromium.net.CronetTestBase;
+import org.chromium.net.CronetTestFramework;
import org.chromium.net.NativeTestServer;
import java.io.ByteArrayOutputStream;
@@ -22,14 +22,13 @@ import java.net.URL;
* Tests for CronetHttpURLStreamHandler class.
*/
public class CronetHttpURLStreamHandlerTest extends CronetTestBase {
- private CronetTestActivity mActivity;
+ private CronetTestFramework mTestFramework;
@Override
protected void setUp() throws Exception {
super.setUp();
- mActivity = launchCronetTestApp();
- assertTrue(NativeTestServer.startNativeTestServer(
- getInstrumentation().getTargetContext()));
+ mTestFramework = startCronetTestFramework();
+ assertTrue(NativeTestServer.startNativeTestServer(getContext()));
}
@Override
@@ -43,7 +42,7 @@ public class CronetHttpURLStreamHandlerTest extends CronetTestBase {
public void testOpenConnectionHttp() throws Exception {
URL url = new URL(NativeTestServer.getEchoMethodURL());
CronetHttpURLStreamHandler streamHandler =
- new CronetHttpURLStreamHandler(mActivity.mCronetEngine);
+ new CronetHttpURLStreamHandler(mTestFramework.mCronetEngine);
HttpURLConnection connection =
(HttpURLConnection) streamHandler.openConnection(url);
assertEquals(200, connection.getResponseCode());
@@ -57,7 +56,7 @@ public class CronetHttpURLStreamHandlerTest extends CronetTestBase {
public void testOpenConnectionHttps() throws Exception {
URL url = new URL("https://example.com");
CronetHttpURLStreamHandler streamHandler =
- new CronetHttpURLStreamHandler(mActivity.mCronetEngine);
+ new CronetHttpURLStreamHandler(mTestFramework.mCronetEngine);
HttpURLConnection connection =
(HttpURLConnection) streamHandler.openConnection(url);
assertNotNull(connection);
@@ -68,7 +67,7 @@ public class CronetHttpURLStreamHandlerTest extends CronetTestBase {
public void testOpenConnectionProtocolNotSupported() throws Exception {
URL url = new URL("ftp://example.com");
CronetHttpURLStreamHandler streamHandler =
- new CronetHttpURLStreamHandler(mActivity.mCronetEngine);
+ new CronetHttpURLStreamHandler(mTestFramework.mCronetEngine);
try {
streamHandler.openConnection(url);
fail();
@@ -82,7 +81,7 @@ public class CronetHttpURLStreamHandlerTest extends CronetTestBase {
public void testOpenConnectionWithProxy() throws Exception {
URL url = new URL(NativeTestServer.getEchoMethodURL());
CronetHttpURLStreamHandler streamHandler =
- new CronetHttpURLStreamHandler(mActivity.mCronetEngine);
+ new CronetHttpURLStreamHandler(mTestFramework.mCronetEngine);
Proxy proxy = new Proxy(Proxy.Type.HTTP,
new InetSocketAddress("127.0.0.1", 8080));
try {

Powered by Google App Engine
This is Rietveld 408576698