Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetHttpURLConnectionTest.java

Issue 1417973002: [Cronet] Switch from InstrumentationTest to junit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address Helen's comments Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetHttpURLConnectionTest.java
diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetHttpURLConnectionTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetHttpURLConnectionTest.java
index 0abce3fecf16f8909858a0baad7b23dfb98876dd..92cd8c359d415c2a388831ddbf6b05909286e39c 100644
--- a/components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetHttpURLConnectionTest.java
+++ b/components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetHttpURLConnectionTest.java
@@ -9,8 +9,8 @@ import android.test.suitebuilder.annotation.SmallTest;
import org.chromium.base.annotations.SuppressFBWarnings;
import org.chromium.base.test.util.Feature;
-import org.chromium.net.CronetTestActivity;
import org.chromium.net.CronetTestBase;
+import org.chromium.net.CronetTestFramework;
import org.chromium.net.MockUrlRequestJobFactory;
import org.chromium.net.NativeTestServer;
import org.chromium.net.UrlRequestException;
@@ -45,12 +45,11 @@ public class CronetHttpURLConnectionTest extends CronetTestBase {
protected void setUp() throws Exception {
super.setUp();
String[] commandLineArgs = {
- CronetTestActivity.CACHE_KEY, CronetTestActivity.CACHE_DISK,
- CronetTestActivity.LIBRARY_INIT_KEY, CronetTestActivity.LIBRARY_INIT_WRAPPER,
+ CronetTestFramework.CACHE_KEY, CronetTestFramework.CACHE_DISK,
+ CronetTestFramework.LIBRARY_INIT_KEY, CronetTestFramework.LIBRARY_INIT_WRAPPER,
};
- launchCronetTestAppWithUrlAndCommandLineArgs(null, commandLineArgs);
- assertTrue(NativeTestServer.startNativeTestServer(
- getInstrumentation().getTargetContext()));
+ startCronetTestFrameworkWithUrlAndCommandLineArgs(null, commandLineArgs);
+ assertTrue(NativeTestServer.startNativeTestServer(getContext()));
}
@Override
@@ -174,8 +173,7 @@ public class CronetHttpURLConnectionTest extends CronetTestBase {
}
checkExceptionsAreThrown(secondConnection);
// Starts the server to avoid crashing on shutdown in tearDown().
- assertTrue(NativeTestServer.startNativeTestServer(
- getInstrumentation().getTargetContext()));
+ assertTrue(NativeTestServer.startNativeTestServer(getContext()));
}
@SmallTest

Powered by Google App Engine
This is Rietveld 408576698