components/cronet/android/test/javatests/src/org/chromium/net/NetworkChangeNotifierTest.java - Issue 1417973002: [Cronet] Switch from InstrumentationTest to junit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/NetworkChangeNotifierTest.java

Issue 1417973002: [Cronet] Switch from InstrumentationTest to junit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address Helen's comments Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cronet/android/test/javatests/src/org/chromium/net/HttpUrlRequestFactoryTest.java ('k') | components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/test/javatests/src/org/chromium/net/NetworkChangeNotifierTest.java

diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/NetworkChangeNotifierTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/NetworkChangeNotifierTest.java

index f9f9782949b51dbc378d15b941468f8eac41a1a6..0e0737dc6155b82a9182fa4bd30aa0110d57ce83 100644

--- a/components/cronet/android/test/javatests/src/org/chromium/net/NetworkChangeNotifierTest.java

+++ b/components/cronet/android/test/javatests/src/org/chromium/net/NetworkChangeNotifierTest.java

@@ -20,8 +20,11 @@ public class NetworkChangeNotifierTest extends CronetTestBase {

@SmallTest

@Feature({"Cronet"})

public void testNetworkChangeNotifierIsInitialized() throws Exception {

- CronetTestActivity activity = launchCronetTestApp();

- assertNotNull(activity);

+ CronetTestFramework testFramework = startCronetTestFramework();

+ assertNotNull(testFramework);

+ // Let Cronet UI thread initialization complete so

+ // NetworkChangeNotifier is initialized for the test.

+ NetworkChangeNotifierTestUtil.flushUiThreadTaskQueue();

assertTrue(NetworkChangeNotifierUtil.isTestIPAddressObserverCalled());

}