Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1417753007: ui: Revert gfx::BufferUsage::SCANOUT to gfx::BufferUsage::GPU_READ_WRITE change. (Closed)

Created:
5 years, 1 month ago by reveman
Modified:
5 years, 1 month ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, danakj+watch_chromium.org, darin (slow to review), darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, jbauman+watch_chromium.org, kalyank, mcasas+watch_chromium.org, ozone-reviews_chromium.org, piman+watch_chromium.org, posciak+watch_chromium.org, qsr+mojo_chromium.org, sievers+watch_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ui: Revert gfx::BufferUsage::SCANOUT to gfx::BufferUsage::GPU_READ_WRITE change. BUG=538325 Committed: https://crrev.com/1108e0b7d14dd6e42eb462d71cc680b4649efb11 Cr-Commit-Position: refs/heads/master@{#357128}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -37 lines) Patch
M components/mus/gles2/command_buffer_local.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/gpu/browser_gpu_memory_buffer_manager.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M content/browser/gpu/gpu_internals_ui.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/gpu/client/command_buffer_proxy_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/client/gpu_memory_buffer_impl_io_surface.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/gpu_memory_buffer_factory_io_surface.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/gpu_memory_buffer_factory_surface_texture.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/media/vaapi_drm_picture.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu_memory_buffer_factory_test_template.h View 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu_memory_buffer_impl_test_template.h View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/in_process_command_buffer.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M mojo/gles2/command_buffer_client_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/buffer_types.h View 1 chunk +4 lines, -2 lines 0 comments Download
M ui/gl/gl_surface_ozone.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/demo/surfaceless_gl_renderer.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/drm/client_native_pixmap_factory_gbm.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/ozone/platform/drm/gpu/drm_thread.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/drm/gpu/gbm_buffer.cc View 4 chunks +5 lines, -11 lines 0 comments Download
M ui/ozone/platform/drm/gpu/gbm_surface_factory.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 30 (12 generated)
reveman
5 years, 1 month ago (2015-10-29 17:13:01 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1417753007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1417753007/1
5 years, 1 month ago (2015-10-29 17:13:32 UTC) #4
spang
lgtm
5 years, 1 month ago (2015-10-29 18:03:38 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/127693)
5 years, 1 month ago (2015-10-29 18:34:33 UTC) #7
alexst (slow to review)
lgtm, thank you.
5 years, 1 month ago (2015-10-29 19:26:47 UTC) #8
reveman
+piman for content/ +fsamuel for components/mus/gles2
5 years, 1 month ago (2015-10-29 19:47:21 UTC) #10
Fady Samuel
MUS lgtm
5 years, 1 month ago (2015-10-29 20:02:00 UTC) #11
piman
lgtm
5 years, 1 month ago (2015-10-29 23:51:55 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1417753007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1417753007/1
5 years, 1 month ago (2015-10-30 00:53:36 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/114171)
5 years, 1 month ago (2015-10-30 00:59:36 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1417753007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1417753007/20001
5 years, 1 month ago (2015-10-30 15:06:44 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/114305)
5 years, 1 month ago (2015-10-30 15:14:54 UTC) #21
reveman
+sky for mojo/
5 years, 1 month ago (2015-10-30 15:19:36 UTC) #23
reveman
+sky for mojo/ (for real this time)
5 years, 1 month ago (2015-10-30 15:20:54 UTC) #25
sky
LGTM
5 years, 1 month ago (2015-10-30 16:58:20 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1417753007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1417753007/20001
5 years, 1 month ago (2015-10-30 16:59:34 UTC) #28
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-10-30 17:05:52 UTC) #29
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 17:06:45 UTC) #30
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/1108e0b7d14dd6e42eb462d71cc680b4649efb11
Cr-Commit-Position: refs/heads/master@{#357128}

Powered by Google App Engine
This is Rietveld 408576698