Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Unified Diff: ui/gfx/buffer_types.h

Issue 1417753007: ui: Revert gfx::BufferUsage::SCANOUT to gfx::BufferUsage::GPU_READ_WRITE change. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/gles2/command_buffer_client_impl.cc ('k') | ui/gl/gl_surface_ozone.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/buffer_types.h
diff --git a/ui/gfx/buffer_types.h b/ui/gfx/buffer_types.h
index 2c879056ad68369b8ae1732a94becf3f63348d80..04e9eaa8ff603d0415054e3ad13178f6698ccce7 100644
--- a/ui/gfx/buffer_types.h
+++ b/ui/gfx/buffer_types.h
@@ -32,10 +32,12 @@ enum class BufferFormat {
// *_CPU_READ_WRITE_* can be mapped into the client's address space and accessed
// by the CPU. *_CPU_READ_WRITE_PERSISTENT adds the additional condition that
// successive Map() calls (with Unmap() calls between) will return a pointer to
-// the same memory contents.
+// the same memory contents. SCANOUT implies GPU_READ_WRITE.
+// TODO(reveman): Add GPU_READ_WRITE for use-cases where SCANOUT is not
+// required.
enum class BufferUsage {
GPU_READ,
- GPU_READ_WRITE,
+ SCANOUT,
GPU_READ_CPU_READ_WRITE,
// TODO(reveman): Merge this with GPU_READ_CPU_READ_WRITE when SurfaceTexture
// backed buffers are single buffered and support it.
« no previous file with comments | « mojo/gles2/command_buffer_client_impl.cc ('k') | ui/gl/gl_surface_ozone.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698