Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 1417503008: [turbofan] Use CompareNilIC for abstract equality with null/undefined. (Closed)

Created:
5 years, 1 month ago by Benedikt Meurer
Modified:
5 years, 1 month ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Use CompareNilIC for abstract equality with null/undefined. Change CompareNilIC to return true/false instead of 1/0, and use the CompareNilICStub in TurboFan for abstract equality with null/undefined. This way we don't always run into the %Equals runtime fallback when comparing objects with null/undefined. R=jarin@chromium.org Committed: https://crrev.com/c9ab36061d26e4f79d50793c6dcbeb4256b76401 Cr-Commit-Position: refs/heads/master@{#31596}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -25 lines) Patch
M src/code-factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/code-factory.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 2 chunks +25 lines, -6 lines 1 comment Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ic/ic.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 1 month ago (2015-10-27 10:46:19 UTC) #1
Benedikt Meurer
Hey Jaro, Here's an implementation of danno's short-term suggestion to use the CompareNilIC, which gives ...
5 years, 1 month ago (2015-10-27 10:47:49 UTC) #2
Jarin
lgtm. https://codereview.chromium.org/1417503008/diff/1/src/compiler/js-typed-lowering.cc File src/compiler/js-typed-lowering.cc (right): https://codereview.chromium.org/1417503008/diff/1/src/compiler/js-typed-lowering.cc#newcode623 src/compiler/js-typed-lowering.cc:623: value->ReplaceInput(0, node); This whole input/use massaging business is ...
5 years, 1 month ago (2015-10-27 11:00:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1417503008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1417503008/1
5 years, 1 month ago (2015-10-27 11:19:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-27 11:21:30 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-10-27 11:21:53 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c9ab36061d26e4f79d50793c6dcbeb4256b76401
Cr-Commit-Position: refs/heads/master@{#31596}

Powered by Google App Engine
This is Rietveld 408576698