Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Side by Side Diff: src/full-codegen/arm64/full-codegen-arm64.cc

Issue 1417503008: [turbofan] Use CompareNilIC for abstract equality with null/undefined. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM64 5 #if V8_TARGET_ARCH_ARM64
6 6
7 #include "src/code-factory.h" 7 #include "src/code-factory.h"
8 #include "src/code-stubs.h" 8 #include "src/code-stubs.h"
9 #include "src/codegen.h" 9 #include "src/codegen.h"
10 #include "src/debug/debug.h" 10 #include "src/debug/debug.h"
(...skipping 4632 matching lines...) Expand 10 before | Expand all | Expand 10 after
4643 4643
4644 if (expr->op() == Token::EQ_STRICT) { 4644 if (expr->op() == Token::EQ_STRICT) {
4645 Heap::RootListIndex nil_value = nil == kNullValue ? 4645 Heap::RootListIndex nil_value = nil == kNullValue ?
4646 Heap::kNullValueRootIndex : 4646 Heap::kNullValueRootIndex :
4647 Heap::kUndefinedValueRootIndex; 4647 Heap::kUndefinedValueRootIndex;
4648 __ CompareRoot(x0, nil_value); 4648 __ CompareRoot(x0, nil_value);
4649 Split(eq, if_true, if_false, fall_through); 4649 Split(eq, if_true, if_false, fall_through);
4650 } else { 4650 } else {
4651 Handle<Code> ic = CompareNilICStub::GetUninitialized(isolate(), nil); 4651 Handle<Code> ic = CompareNilICStub::GetUninitialized(isolate(), nil);
4652 CallIC(ic, expr->CompareOperationFeedbackId()); 4652 CallIC(ic, expr->CompareOperationFeedbackId());
4653 __ CompareAndSplit(x0, 0, ne, if_true, if_false, fall_through); 4653 __ CompareRoot(x0, Heap::kTrueValueRootIndex);
4654 Split(eq, if_true, if_false, fall_through);
4654 } 4655 }
4655 4656
4656 context()->Plug(if_true, if_false); 4657 context()->Plug(if_true, if_false);
4657 } 4658 }
4658 4659
4659 4660
4660 void FullCodeGenerator::VisitThisFunction(ThisFunction* expr) { 4661 void FullCodeGenerator::VisitThisFunction(ThisFunction* expr) {
4661 __ Ldr(x0, MemOperand(fp, JavaScriptFrameConstants::kFunctionOffset)); 4662 __ Ldr(x0, MemOperand(fp, JavaScriptFrameConstants::kFunctionOffset));
4662 context()->Plug(x0); 4663 context()->Plug(x0);
4663 } 4664 }
(...skipping 514 matching lines...) Expand 10 before | Expand all | Expand 10 after
5178 } 5179 }
5179 5180
5180 return INTERRUPT; 5181 return INTERRUPT;
5181 } 5182 }
5182 5183
5183 5184
5184 } // namespace internal 5185 } // namespace internal
5185 } // namespace v8 5186 } // namespace v8
5186 5187
5187 #endif // V8_TARGET_ARCH_ARM64 5188 #endif // V8_TARGET_ARCH_ARM64
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698