Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Side by Side Diff: src/full-codegen/x87/full-codegen-x87.cc

Issue 1417503008: [turbofan] Use CompareNilIC for abstract equality with null/undefined. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_X87 5 #if V8_TARGET_ARCH_X87
6 6
7 #include "src/code-factory.h" 7 #include "src/code-factory.h"
8 #include "src/code-stubs.h" 8 #include "src/code-stubs.h"
9 #include "src/codegen.h" 9 #include "src/codegen.h"
10 #include "src/debug/debug.h" 10 #include "src/debug/debug.h"
(...skipping 4842 matching lines...) Expand 10 before | Expand all | Expand 10 after
4853 4853
4854 Handle<Object> nil_value = nil == kNullValue 4854 Handle<Object> nil_value = nil == kNullValue
4855 ? isolate()->factory()->null_value() 4855 ? isolate()->factory()->null_value()
4856 : isolate()->factory()->undefined_value(); 4856 : isolate()->factory()->undefined_value();
4857 if (expr->op() == Token::EQ_STRICT) { 4857 if (expr->op() == Token::EQ_STRICT) {
4858 __ cmp(eax, nil_value); 4858 __ cmp(eax, nil_value);
4859 Split(equal, if_true, if_false, fall_through); 4859 Split(equal, if_true, if_false, fall_through);
4860 } else { 4860 } else {
4861 Handle<Code> ic = CompareNilICStub::GetUninitialized(isolate(), nil); 4861 Handle<Code> ic = CompareNilICStub::GetUninitialized(isolate(), nil);
4862 CallIC(ic, expr->CompareOperationFeedbackId()); 4862 CallIC(ic, expr->CompareOperationFeedbackId());
4863 __ test(eax, eax); 4863 __ cmp(eax, isolate()->factory()->true_value());
4864 Split(not_zero, if_true, if_false, fall_through); 4864 Split(equal, if_true, if_false, fall_through);
4865 } 4865 }
4866 context()->Plug(if_true, if_false); 4866 context()->Plug(if_true, if_false);
4867 } 4867 }
4868 4868
4869 4869
4870 void FullCodeGenerator::VisitThisFunction(ThisFunction* expr) { 4870 void FullCodeGenerator::VisitThisFunction(ThisFunction* expr) {
4871 __ mov(eax, Operand(ebp, JavaScriptFrameConstants::kFunctionOffset)); 4871 __ mov(eax, Operand(ebp, JavaScriptFrameConstants::kFunctionOffset));
4872 context()->Plug(eax); 4872 context()->Plug(eax);
4873 } 4873 }
4874 4874
(...skipping 178 matching lines...) Expand 10 before | Expand all | Expand 10 after
5053 Assembler::target_address_at(call_target_address, 5053 Assembler::target_address_at(call_target_address,
5054 unoptimized_code)); 5054 unoptimized_code));
5055 return OSR_AFTER_STACK_CHECK; 5055 return OSR_AFTER_STACK_CHECK;
5056 } 5056 }
5057 5057
5058 5058
5059 } // namespace internal 5059 } // namespace internal
5060 } // namespace v8 5060 } // namespace v8
5061 5061
5062 #endif // V8_TARGET_ARCH_X87 5062 #endif // V8_TARGET_ARCH_X87
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698