Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Side by Side Diff: src/full-codegen/arm/full-codegen-arm.cc

Issue 1417503008: [turbofan] Use CompareNilIC for abstract equality with null/undefined. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM 5 #if V8_TARGET_ARCH_ARM
6 6
7 #include "src/code-factory.h" 7 #include "src/code-factory.h"
8 #include "src/code-stubs.h" 8 #include "src/code-stubs.h"
9 #include "src/codegen.h" 9 #include "src/codegen.h"
10 #include "src/debug/debug.h" 10 #include "src/debug/debug.h"
(...skipping 4917 matching lines...) Expand 10 before | Expand all | Expand 10 after
4928 if (expr->op() == Token::EQ_STRICT) { 4928 if (expr->op() == Token::EQ_STRICT) {
4929 Heap::RootListIndex nil_value = nil == kNullValue ? 4929 Heap::RootListIndex nil_value = nil == kNullValue ?
4930 Heap::kNullValueRootIndex : 4930 Heap::kNullValueRootIndex :
4931 Heap::kUndefinedValueRootIndex; 4931 Heap::kUndefinedValueRootIndex;
4932 __ LoadRoot(r1, nil_value); 4932 __ LoadRoot(r1, nil_value);
4933 __ cmp(r0, r1); 4933 __ cmp(r0, r1);
4934 Split(eq, if_true, if_false, fall_through); 4934 Split(eq, if_true, if_false, fall_through);
4935 } else { 4935 } else {
4936 Handle<Code> ic = CompareNilICStub::GetUninitialized(isolate(), nil); 4936 Handle<Code> ic = CompareNilICStub::GetUninitialized(isolate(), nil);
4937 CallIC(ic, expr->CompareOperationFeedbackId()); 4937 CallIC(ic, expr->CompareOperationFeedbackId());
4938 __ cmp(r0, Operand(0)); 4938 __ CompareRoot(r0, Heap::kTrueValueRootIndex);
4939 Split(ne, if_true, if_false, fall_through); 4939 Split(eq, if_true, if_false, fall_through);
4940 } 4940 }
4941 context()->Plug(if_true, if_false); 4941 context()->Plug(if_true, if_false);
4942 } 4942 }
4943 4943
4944 4944
4945 void FullCodeGenerator::VisitThisFunction(ThisFunction* expr) { 4945 void FullCodeGenerator::VisitThisFunction(ThisFunction* expr) {
4946 __ ldr(r0, MemOperand(fp, JavaScriptFrameConstants::kFunctionOffset)); 4946 __ ldr(r0, MemOperand(fp, JavaScriptFrameConstants::kFunctionOffset));
4947 context()->Plug(r0); 4947 context()->Plug(r0);
4948 } 4948 }
4949 4949
(...skipping 241 matching lines...) Expand 10 before | Expand all | Expand 10 after
5191 DCHECK(interrupt_address == 5191 DCHECK(interrupt_address ==
5192 isolate->builtins()->OsrAfterStackCheck()->entry()); 5192 isolate->builtins()->OsrAfterStackCheck()->entry());
5193 return OSR_AFTER_STACK_CHECK; 5193 return OSR_AFTER_STACK_CHECK;
5194 } 5194 }
5195 5195
5196 5196
5197 } // namespace internal 5197 } // namespace internal
5198 } // namespace v8 5198 } // namespace v8
5199 5199
5200 #endif // V8_TARGET_ARCH_ARM 5200 #endif // V8_TARGET_ARCH_ARM
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698