Move z-index property handling into CSSPropertyParser

Move z-index property handling into CSSPropertyParser

Move z-index property handling from LegacyCSSPropertyParser
into CSSPropertyParser.

This property needs to be of type Integer in order to serialize correctly.
To support this, make consumeInteger generate CSSPrimitiveValues of this
type, and change the CSSValuePool integer caching (for integer values 0-255)
to be of type Integer too.

BUG=499780
Committed: https://crrev.com/13ee1c0bcba54eb3d4bfd46b7bfc89396f996710
Cr-Commit-Position: refs/heads/master@{#356767}

[rwlbuis, 2015-10-20 20:50:59]

Description was changed from

==========
zindex wip

BUG=
==========

to

==========
Move z-index property handling into CSSPropertyParser
    
Move z-index property handling from LegacyCSSPropertyParser
into CSSPropertyParser.

BUG=499780
==========

[rwlbuis, 2015-10-20 20:55:22]

Description was changed from

==========
Move z-index property handling into CSSPropertyParser
    
Move z-index property handling from LegacyCSSPropertyParser
into CSSPropertyParser.

BUG=499780
==========

to

==========
Move z-index property handling into CSSPropertyParser
    
Move z-index property handling from LegacyCSSPropertyParser
into CSSPropertyParser.

This property needs to be of type Integer in order to serialize correctly.
To support this, make consumeInteger generate CSSPrimitiveValues of this
type, and change the CSSValuePool integer caching (for integer values 0-255)
to be of type Integer too.

BUG=499780
==========

[rwlbuis, 2015-10-20 20:56:30]

rob.buis@samsung.com changed reviewers:
+ timloh@chromium.org

[rwlbuis, 2015-10-20 20:56:31]

PTAL. We may need to adjust some ASSERTs that assert Number right now in the
future.

[rwlbuis, 2015-10-28 23:37:35]

On 2015/10/20 20:56:31, rwlbuis wrote:
> PTAL. We may need to adjust some ASSERTs that assert Number right now in the
> future.

Phew, had to rebase, but green again...

[Timothy Loh, 2015-10-29 02:37:59]

On 2015/10/28 23:37:35, rwlbuis wrote:
> On 2015/10/20 20:56:31, rwlbuis wrote:
> > PTAL. We may need to adjust some ASSERTs that assert Number right now in the
> > future.
> 
> Phew, had to rebase, but green again...

lgtm, but mention the change to LineClamp in the description

[Timothy Loh, 2015-10-29 02:38:06]

https://codereview.chromium.org/1417463003/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/css/CSSValuePool.cpp (right):

https://codereview.chromium.org/1417463003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/css/CSSValuePool.cpp:116: case
CSSPrimitiveValue::UnitType::Integer:
This bit seems a bit weird, but I think it's okay for now...

[rwlbuis, 2015-10-29 03:38:16]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2015-10-29 03:38:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1417463003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1417463003/100001

[Timothy Loh, 2015-10-29 03:53:42]

https://codereview.chromium.org/1417463003/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp (right):

https://codereview.chromium.org/1417463003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:1147: static
PassRefPtrWillBeRawPtr<CSSValue> consumeZIndex(CSSParserTokenRange& range)
errr... can we put this somewhere other than in the middle of all the animation
functions :S

[rwlbuis, 2015-10-29 04:33:08]

On 2015/10/29 03:53:42, Timothy Loh wrote:
>
https://codereview.chromium.org/1417463003/diff/100001/third_party/WebKit/Sou...
> File third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp (right):
> 
>
https://codereview.chromium.org/1417463003/diff/100001/third_party/WebKit/Sou...
> third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:1147: static
> PassRefPtrWillBeRawPtr<CSSValue> consumeZIndex(CSSParserTokenRange& range)
> errr... can we put this somewhere other than in the middle of all the
animation
> functions :S

Probably happened because of some messy rebase... Will move it to a better place
by "re-using" some other patch :)

[commit-bot: I haz the power, 2015-10-29 04:55:37]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-10-29 04:56:15]

Patchset 6 (id:??) landed as
https://crrev.com/13ee1c0bcba54eb3d4bfd46b7bfc89396f996710
Cr-Commit-Position: refs/heads/master@{#356767}