third_party/WebKit/Source/core/css/CSSValuePool.cpp - Issue 1417463003: Move z-index property handling into CSSPropertyParser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSValuePool.cpp

Issue 1417463003: Move z-index property handling into CSSPropertyParser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase again! Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h ('k') | third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp » ('j') | third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/CSSValuePool.cpp

diff --git a/third_party/WebKit/Source/core/css/CSSValuePool.cpp b/third_party/WebKit/Source/core/css/CSSValuePool.cpp

index 97723864efb0c0832308eed2f255627815ce9048..58bdbe0129766e8cafa7c7ce61cdb076b719fe29 100644

--- a/third_party/WebKit/Source/core/css/CSSValuePool.cpp

+++ b/third_party/WebKit/Source/core/css/CSSValuePool.cpp

@@ -113,8 +113,9 @@ PassRefPtrWillBeRawPtr<CSSPrimitiveValue> CSSValuePool::createValue(double value

m_percentValueCache[intValue] = CSSPrimitiveValue::create(value, type);

return m_percentValueCache[intValue];

case CSSPrimitiveValue::UnitType::Number:

+ case CSSPrimitiveValue::UnitType::Integer:

Timothy Loh 2015/10/29 02:38:05 This bit seems a bit weird, but I think it's okay

if (!m_numberValueCache[intValue])

- m_numberValueCache[intValue] = CSSPrimitiveValue::create(value, type);

+ m_numberValueCache[intValue] = CSSPrimitiveValue::create(value, CSSPrimitiveValue::UnitType::Integer);

return m_numberValueCache[intValue];

default:

return CSSPrimitiveValue::create(value, type);