Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Unified Diff: third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp

Issue 1417463003: Move z-index property handling into CSSPropertyParser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase again! Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp
diff --git a/third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp b/third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp
index 15bb12783793ade24b77d430b0ac983d54952504..2a2f12d64346076213656983882dd5b72fb7d180 100644
--- a/third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp
+++ b/third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp
@@ -659,15 +659,6 @@ bool CSSPropertyParser::parseValue(CSSPropertyID unresolvedProperty, bool import
validPrimitive = validUnit(value, FLength | FPercent | unitless);
break;
- case CSSPropertyZIndex: // auto | <integer> | inherit
- if (id == CSSValueAuto) {
- validPrimitive = true;
- } else if (validUnit(value, FInteger)) {
- addProperty(propId, cssValuePool().createValue(value->fValue, CSSPrimitiveValue::UnitType::Integer), important);
- return true;
- }
- break;
-
case CSSPropertyTextDecoration:
// Fall through 'text-decoration-line' parsing if CSS 3 Text Decoration
// is disabled to match CSS 2.1 rules for parsing 'text-decoration'.
@@ -1240,6 +1231,7 @@ bool CSSPropertyParser::parseValue(CSSPropertyID unresolvedProperty, bool import
case CSSPropertyWebkitTapHighlightColor:
case CSSPropertyWebkitTextFillColor:
case CSSPropertyColor:
+ case CSSPropertyZIndex:
validPrimitive = false;
break;

Powered by Google App Engine
This is Rietveld 408576698