third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp - Issue 1417463003: Move z-index property handling into CSSPropertyParser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp

Issue 1417463003: Move z-index property handling into CSSPropertyParser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase again! Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp

diff --git a/third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp b/third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp

index 82e384900049f2ed5302ff2879a437543655413b..e879977f18d51c1654e19b6172d6588d7d65115a 100644

--- a/third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp

+++ b/third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp

@@ -786,6 +786,7 @@ bool CSSPrimitiveValue::equals(const CSSPrimitiveValue& other) const

case UnitType::Unknown:

return false;

case UnitType::Number:

+ case UnitType::Integer:

case UnitType::Percentage:

case UnitType::Ems:

case UnitType::Exs:

@@ -817,7 +818,6 @@ bool CSSPrimitiveValue::equals(const CSSPrimitiveValue& other) const

return m_value.valueID == other.m_value.valueID;

case UnitType::Calc:

return m_value.calc && other.m_value.calc && m_value.calc->equals(*other.m_value.calc);

- case UnitType::Integer:

case UnitType::Chs:

case UnitType::CalcPercentageWithNumber:

case UnitType::CalcPercentageWithLength:

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h » ('j') | third_party/WebKit/Source/core/css/CSSValuePool.cpp » ('J')