Issue 141743005: Extensions: Make it possible for permission parsing code to return a detailed error message.

Issue 141743005: Extensions: Make it possible for permission parsing code to return a detailed error message. (Closed)

Created:
6 years, 11 months ago by Lei Zhang

Modified:
6 years, 10 months ago

Reviewers:
Yoyo Zhou

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Extensions: Make it possible for permission parsing code to return a detailed error message. BUG=337758 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247624

Patch Set 2 : #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+174 lines, -150 lines)			Patch
M	chrome/browser/extensions/api/permissions/permissions_api_helpers.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_prefs_unittest.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/common/extensions/permissions/bluetooth_permission.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/common/extensions/permissions/bluetooth_permission.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/common/extensions/permissions/media_galleries_permission.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions/permissions/media_galleries_permission.cc	View	1	4 chunks	+22 lines, -9 lines	0 comments	Download
M	chrome/common/extensions/permissions/media_galleries_permission_unittest.cc	View		8 chunks	+62 lines, -30 lines	0 comments	Download
M	chrome/common/extensions/permissions/permission_set_unittest.cc	View		9 chunks	+9 lines, -27 lines	0 comments	Download
M	chrome/common/extensions/permissions/set_disjunction_permission.h	View		1 chunk	+14 lines, -9 lines	0 comments	Download
M	chrome/common/extensions/permissions/settings_override_permission.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions/permissions/settings_override_permission.cc	View		3 chunks	+10 lines, -13 lines	0 comments	Download
M	chrome/common/extensions/permissions/socket_permission_unittest.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/common/extensions/permissions/usb_device_permission_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	extensions/common/manifest_constants.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	extensions/common/manifest_constants.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	extensions/common/permissions/api_permission.h	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	extensions/common/permissions/api_permission.cc	View		2 chunks	+9 lines, -11 lines	0 comments	Download
M	extensions/common/permissions/api_permission_set.cc	View		1 chunk	+12 lines, -3 lines	0 comments	Download
M	extensions/common/permissions/api_permission_set_unittest.cc	View		10 chunks	+10 lines, -30 lines	0 comments	Download
M	extensions/common/permissions/permissions_data_unittest.cc	View		1 chunk	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Yoyo Zhou

LGTM https://codereview.chromium.org/141743005/diff/40001/chrome/common/extensions/permissions/media_galleries_permission.cc File chrome/common/extensions/permissions/media_galleries_permission.cc (right): https://codereview.chromium.org/141743005/diff/40001/chrome/common/extensions/permissions/media_galleries_permission.cc#newcode28 chrome/common/extensions/permissions/media_galleries_permission.cc:28: error_msg = "copyTo permission requires delete permission"; I ...

6 years, 10 months ago (2014-01-29 00:39:58 UTC) #2

Lei Zhang

https://codereview.chromium.org/141743005/diff/40001/chrome/common/extensions/permissions/media_galleries_permission.cc File chrome/common/extensions/permissions/media_galleries_permission.cc (right): https://codereview.chromium.org/141743005/diff/40001/chrome/common/extensions/permissions/media_galleries_permission.cc#newcode28 chrome/common/extensions/permissions/media_galleries_permission.cc:28: error_msg = "copyTo permission requires delete permission"; On 2014/01/29 ...

6 years, 10 months ago (2014-01-29 00:47:35 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/141743005/60001

6 years, 10 months ago (2014-01-29 00:51:31 UTC) #5

Message was sent while issue was closed.

Change committed as 247624

Expand Messages | Collapse Messages