chrome/common/extensions/permissions/socket_permission_unittest.cc - Issue 141743005: Extensions: Make it possible for permission parsing code to return a detailed error message.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/permissions/socket_permission_unittest.cc

Issue 141743005: Extensions: Make it possible for permission parsing code to return a detailed error message. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/permissions/settings_override_permission.cc ('k') | chrome/common/extensions/permissions/usb_device_permission_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/permissions/socket_permission_unittest.cc

===================================================================

--- chrome/common/extensions/permissions/socket_permission_unittest.cc (revision 247036)

+++ chrome/common/extensions/permissions/socket_permission_unittest.cc (working copy)

@@ -293,7 +293,7 @@

value->AppendString("tcp-connect:*.example.com:80");

value->AppendString("udp-bind::8080");

value->AppendString("udp-send-to::8888");

- ASSERT_TRUE(permission1->FromValue(value.get()));

+ ASSERT_TRUE(permission1->FromValue(value.get(), NULL));

EXPECT_FALSE(permission1->Equal(permission2.get()));

@@ -317,13 +317,13 @@

value->AppendString("tcp-connect:*.example.com:80");

value->AppendString("udp-bind::8080");

value->AppendString("udp-send-to::8888");

- ASSERT_TRUE(permission1->FromValue(value.get()));

+ ASSERT_TRUE(permission1->FromValue(value.get(), NULL));

EXPECT_FALSE(permission1->Equal(permission2.get()));

scoped_ptr<base::Value> vtmp(permission1->ToValue());

ASSERT_TRUE(vtmp);

- ASSERT_TRUE(permission2->FromValue(vtmp.get()));

+ ASSERT_TRUE(permission2->FromValue(vtmp.get(), NULL));

EXPECT_TRUE(permission1->Equal(permission2.get()));

}