Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Unified Diff: extensions/common/permissions/api_permission_set.cc

Issue 141743005: Extensions: Make it possible for permission parsing code to return a detailed error message. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/permissions/api_permission_set.cc
===================================================================
--- extensions/common/permissions/api_permission_set.cc (revision 247036)
+++ extensions/common/permissions/api_permission_set.cc (working copy)
@@ -41,10 +41,19 @@
return false;
}
- if (!permission->FromValue(permission_value)) {
+ std::string error_details;
+ if (!permission->FromValue(permission_value, &error_details)) {
if (error) {
- *error = ErrorUtils::FormatErrorMessageUTF16(
- errors::kInvalidPermission, permission_info->name());
+ if (error_details.empty()) {
+ *error = ErrorUtils::FormatErrorMessageUTF16(
+ errors::kInvalidPermission,
+ permission_info->name());
+ } else {
+ *error = ErrorUtils::FormatErrorMessageUTF16(
+ errors::kInvalidPermissionWithDetail,
+ permission_info->name(),
+ error_details);
+ }
return false;
}
LOG(WARNING) << "Parse permission failed.";
« no previous file with comments | « extensions/common/permissions/api_permission.cc ('k') | extensions/common/permissions/api_permission_set_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698