chrome/common/extensions/permissions/bluetooth_permission.cc - Issue 141743005: Extensions: Make it possible for permission parsing code to return a detailed error message.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/permissions/bluetooth_permission.cc

Issue 141743005: Extensions: Make it possible for permission parsing code to return a detailed error message. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/permissions/bluetooth_permission.h ('k') | chrome/common/extensions/permissions/media_galleries_permission.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/permissions/bluetooth_permission.cc

===================================================================

--- chrome/common/extensions/permissions/bluetooth_permission.cc (revision 247036)

+++ chrome/common/extensions/permissions/bluetooth_permission.cc (working copy)

@@ -25,7 +25,8 @@

BluetoothPermission::~BluetoothPermission() {

}

-bool BluetoothPermission::FromValue(const base::Value* value) {

+bool BluetoothPermission::FromValue(const base::Value* value,

+ std::string* error) {

// Value may be omitted to gain access to non-profile functions.

if (!value)

return true;

@@ -36,7 +37,7 @@

return true;

if (!SetDisjunctionPermission<BluetoothPermissionData,

- BluetoothPermission>::FromValue(value)) {

+ BluetoothPermission>::FromValue(value, error)) {

return false;

}