Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 1416663004: [x64] Replace movaps with appropriate vmov* instructions when AVX is enabled. (Closed)

Created:
5 years, 2 months ago by alph
Modified:
5 years, 2 months ago
Reviewers:
Benedikt Meurer, yurys
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[x64] Replace movaps with appropriate vmov* instructions when AVX is enabled. BUG=v8:4406 LOG=N Committed: https://crrev.com/fa60b82b194c838b87a14d2617cc46dd1b032ea5 Cr-Commit-Position: refs/heads/master@{#31391}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -27 lines) Patch
M src/compiler/x64/code-generator-x64.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M src/x64/assembler-x64.h View 5 chunks +15 lines, -2 lines 0 comments Download
M src/x64/assembler-x64.cc View 3 chunks +13 lines, -0 lines 0 comments Download
M src/x64/disasm-x64.cc View 3 chunks +21 lines, -0 lines 0 comments Download
M src/x64/lithium-gap-resolver-x64.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 2 chunks +3 lines, -1 line 0 comments Download
M src/x64/macro-assembler-x64.cc View 5 chunks +23 lines, -7 lines 0 comments Download
M test/cctest/test-assembler-x64.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M test/cctest/test-disasm-x64.cc View 3 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
alph
5 years, 2 months ago (2015-10-19 23:21:28 UTC) #2
Benedikt Meurer
lgtm
5 years, 2 months ago (2015-10-20 03:36:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1416663004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1416663004/1
5 years, 2 months ago (2015-10-20 04:34:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-20 04:58:10 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-20 04:58:26 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fa60b82b194c838b87a14d2617cc46dd1b032ea5
Cr-Commit-Position: refs/heads/master@{#31391}

Powered by Google App Engine
This is Rietveld 408576698