Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 1415513010: Web Animations: Add SVGRectInterpolationType (Closed)

Created:
5 years, 1 month ago by alancutter (OOO until 2018)
Modified:
5 years, 1 month ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@_svgIOIInterpolationType
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Web Animations: Add SVGRectInterpolationType This change migrates the "viewBox" SVG attribute animations over to SVGRectInterpolationType and enables additive keyframe composite modes as well as neutral keyframes. This is a rebased reupload of: https://codereview.chromium.org/1431593004 BUG=530436 Committed: https://crrev.com/5be143be792baea9d6c8328a16a87ee9e74375d5 Cr-Commit-Position: refs/heads/master@{#361294}

Patch Set 1 #

Patch Set 2 : Clean up #

Patch Set 3 : g mb #

Patch Set 4 : neutralKeyframe #

Messages

Total messages: 25 (11 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415513010/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415513010/40001
5 years, 1 month ago (2015-11-17 07:18:28 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/95379) ios_rel_device_ninja on ...
5 years, 1 month ago (2015-11-17 07:22:36 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415513010/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415513010/40001
5 years, 1 month ago (2015-11-18 00:27:46 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/136484)
5 years, 1 month ago (2015-11-18 01:43:35 UTC) #8
alancutter (OOO until 2018)
5 years, 1 month ago (2015-11-18 09:13:04 UTC) #10
Eric Willigers
lgtm
5 years, 1 month ago (2015-11-20 02:18:45 UTC) #11
dstockwell
lgtm
5 years, 1 month ago (2015-11-23 04:54:07 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415513010/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415513010/60001
5 years, 1 month ago (2015-11-23 23:09:06 UTC) #14
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/139198)
5 years, 1 month ago (2015-11-24 00:54:46 UTC) #16
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415513010/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415513010/60001
5 years, 1 month ago (2015-11-24 07:18:45 UTC) #18
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-24 08:25:43 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415513010/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415513010/60001
5 years, 1 month ago (2015-11-24 08:42:53 UTC) #23
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 1 month ago (2015-11-24 08:49:25 UTC) #24
commit-bot: I haz the power
5 years, 1 month ago (2015-11-24 08:50:31 UTC) #25
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/5be143be792baea9d6c8328a16a87ee9e74375d5
Cr-Commit-Position: refs/heads/master@{#361294}

Powered by Google App Engine
This is Rietveld 408576698