Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1431593004: Web Animations: Migrate SVG Rect interpolation to interpolation types (Closed)

Created:
5 years, 1 month ago by nainar
Modified:
5 years, 1 month ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, krit, Eric Willigers, f(malita), fs, gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Web Animations: Migrate SVG Rect interpolation to interpolation types BUG=530436

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 4

Patch Set 5 : #

Patch Set 6 : #

Total comments: 1

Patch Set 7 : #

Total comments: 1

Patch Set 8 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -89 lines) Patch
A third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-viewBox-composition.html View 1 2 3 4 5 6 7 1 chunk +80 lines, -0 lines 0 comments Download
D third_party/WebKit/Source/core/animation/RectSVGInterpolation.h View 1 1 chunk +0 lines, -40 lines 0 comments Download
D third_party/WebKit/Source/core/animation/RectSVGInterpolation.cpp View 1 1 chunk +0 lines, -34 lines 0 comments Download
A + third_party/WebKit/Source/core/animation/SVGRectInterpolationType.h View 1 2 3 1 chunk +5 lines, -10 lines 0 comments Download
A third_party/WebKit/Source/core/animation/SVGRectInterpolationType.cpp View 1 2 3 4 1 chunk +46 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/StringKeyframe.cpp View 1 2 3 3 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGRect.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
nainar
5 years, 1 month ago (2015-11-03 04:12:52 UTC) #2
alancutter (OOO until 2018)
https://codereview.chromium.org/1431593004/diff/60001/third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-viewBox-composition.html File third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-viewBox-composition.html (right): https://codereview.chromium.org/1431593004/diff/60001/third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-viewBox-composition.html#newcode16 third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-viewBox-composition.html:16: underlying: '3', These underlying values look like they won't ...
5 years, 1 month ago (2015-11-03 04:41:44 UTC) #3
alancutter (OOO until 2018)
https://codereview.chromium.org/1431593004/diff/100001/third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-viewBox-composition.html File third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-viewBox-composition.html (right): https://codereview.chromium.org/1431593004/diff/100001/third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-viewBox-composition.html#newcode66 third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-viewBox-composition.html:66: fromComposite: 'neutral', Neutral keyframes are tested using: from: '', ...
5 years, 1 month ago (2015-11-03 05:39:26 UTC) #4
nainar
https://codereview.chromium.org/1431593004/diff/60001/third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-viewBox-composition.html File third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-viewBox-composition.html (right): https://codereview.chromium.org/1431593004/diff/60001/third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-viewBox-composition.html#newcode16 third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-viewBox-composition.html:16: underlying: '3', Done. https://codereview.chromium.org/1431593004/diff/60001/third_party/WebKit/Source/core/animation/SVGRectInterpolationType.cpp File third_party/WebKit/Source/core/animation/SVGRectInterpolationType.cpp (right): https://codereview.chromium.org/1431593004/diff/60001/third_party/WebKit/Source/core/animation/SVGRectInterpolationType.cpp#newcode16 third_party/WebKit/Source/core/animation/SVGRectInterpolationType.cpp:16: ...
5 years, 1 month ago (2015-11-03 06:37:47 UTC) #6
alancutter (OOO until 2018)
https://codereview.chromium.org/1431593004/diff/120001/third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-viewBox-composition.html File third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-viewBox-composition.html (right): https://codereview.chromium.org/1431593004/diff/120001/third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-viewBox-composition.html#newcode16 third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-viewBox-composition.html:16: underlying: '0, 0, 0, 0', We should be testing ...
5 years, 1 month ago (2015-11-03 07:04:24 UTC) #7
nainar
5 years, 1 month ago (2015-11-03 07:40:55 UTC) #8 

          

          

        


      

    

    

  











      		
    

  





  
    
  






  Powered by Google App Engine





  
This is Rietveld 408576698