Issue 1416703004: Web Animations: Add SVGIntegerOptionalIntegerInterpolationType

Issue 1416703004: Web Animations: Add SVGIntegerOptionalIntegerInterpolationType (Closed)

Created:
5 years, 1 month ago by alancutter (OOO until 2018)

Modified:
5 years ago

Reviewers:
dstockwell, Eric Willigers

CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, krit, Eric Willigers, f(malita), fs, gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans

Base URL:
https://chromium.googlesource.com/chromium/src.git@_svgNONInterpolationType

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Web Animations: Add SVGIntegerOptionalIntegerInterpolationType This change migrates the "order" SVG attribute animations over to SVGIntegerOptionalIntegerInterpolationType and enables additive keyframe composite modes as well as neutral keyframes. This is a rebased reupload of: https://codereview.chromium.org/1417483015/ BUG=530436 Committed: https://crrev.com/a8e124a28cc8c519c0fd08ca4b4ff66f62af0b9a Cr-Commit-Position: refs/heads/master@{#361289}

Patch Set 1 #

Patch Set 2 : Clean up #

Patch Set 3 : Rebased #

Patch Set 4 : Update expectations #

Patch Set 5 : Fix test #

Total comments: 2

Patch Set 6 : Rebased #

Patch Set 7 : neutralKeyframe #

Created: 5 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+125 lines, -100 lines)			Patch
A	third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-order-composition.html	View	1 2 3 4 5 6	1 chunk	+64 lines, -0 lines	0 comments	Download
M	third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/resources/interpolation-test.js	View	1 2 3 4 5	1 chunk	+2 lines, -2 lines	0 comments	Download
D	third_party/WebKit/Source/core/animation/IntegerOptionalIntegerSVGInterpolation.h	View		1 chunk	+0 lines, -44 lines	0 comments	Download
D	third_party/WebKit/Source/core/animation/IntegerOptionalIntegerSVGInterpolation.cpp	View		1 chunk	+0 lines, -40 lines	0 comments	Download
A +	third_party/WebKit/Source/core/animation/SVGIntegerOptionalIntegerInterpolationType.h	View		2 chunks	+5 lines, -5 lines	0 comments	Download
A	third_party/WebKit/Source/core/animation/SVGIntegerOptionalIntegerInterpolationType.cpp	View	1	1 chunk	+46 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/animation/StringKeyframe.cpp	View	1 2	5 chunks	+4 lines, -5 lines	0 comments	Download
M	third_party/WebKit/Source/core/core.gypi	View	1 2 3 4 5	2 chunks	+2 lines, -2 lines	0 comments	Download
M	third_party/WebKit/Source/core/svg/SVGIntegerOptionalInteger.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Depends on Patchset:

Issue 1418193007 Patch 60001

Dependent Patchsets:

Issue 1415513010 Patch 60001

Messages

Total messages: 32 (14 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1416703004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1416703004/40001

5 years, 1 month ago (2015-11-17 07:18:29 UTC) #2

commit-bot: I haz the power

Dry run: Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/95378) ios_rel_device_ninja on ...

5 years, 1 month ago (2015-11-17 07:22:37 UTC) #4

commit-bot: I haz the power

5 years, 1 month ago (2015-11-18 00:27:47 UTC) #6

commit-bot: I haz the power

Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/142246)

5 years, 1 month ago (2015-11-18 02:02:30 UTC) #8

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1416703004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1416703004/60001

5 years, 1 month ago (2015-11-19 00:55:14 UTC) #12

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1416703004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1416703004/80001

5 years, 1 month ago (2015-11-19 04:26:04 UTC) #14

commit-bot: I haz the power

Dry run: This issue passed the CQ dry run.

5 years, 1 month ago (2015-11-19 06:48:04 UTC) #16

Eric Willigers

lgtm IntegerOptionalIntegerSVGInterpolation was written to support both order and filterRes. filterRes has since been deprecated ...

5 years, 1 month ago (2015-11-20 03:01:18 UTC) #17

dstockwell

lgtm https://codereview.chromium.org/1416703004/diff/80001/third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/resources/interpolation-test.js File third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/resources/interpolation-test.js (right): https://codereview.chromium.org/1416703004/diff/80001/third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/resources/interpolation-test.js#newcode371 third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/resources/interpolation-test.js:371: function reprKeyframe(x) { this isn't python. repr is ...

5 years, 1 month ago (2015-11-23 04:51:44 UTC) #18

alancutter (OOO until 2018)

https://codereview.chromium.org/1416703004/diff/80001/third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/resources/interpolation-test.js File third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/resources/interpolation-test.js (right): https://codereview.chromium.org/1416703004/diff/80001/third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/resources/interpolation-test.js#newcode371 third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/resources/interpolation-test.js:371: function reprKeyframe(x) { On 2015/11/23 at 04:51:43, dstockwell wrote: ...

5 years, 1 month ago (2015-11-23 06:10:36 UTC) #19

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1416703004/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1416703004/120001

5 years ago (2015-11-23 22:27:10 UTC) #21

commit-bot: I haz the power

Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/145086)

5 years ago (2015-11-23 23:41:36 UTC) #23

commit-bot: I haz the power

5 years ago (2015-11-24 07:18:46 UTC) #25

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1416703004/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1416703004/120001

5 years ago (2015-11-24 08:34:27 UTC) #30

commit-bot: I haz the power

5 years ago (2015-11-24 08:40:57 UTC) #32

Message was sent while issue was closed.

Patchset 7 (id:??) landed as
https://crrev.com/a8e124a28cc8c519c0fd08ca4b4ff66f62af0b9a
Cr-Commit-Position: refs/heads/master@{#361289}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages