Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1419733009: Web Animations: Add SVGNumberListInterpolationType (Closed)

Created:
5 years, 1 month ago by alancutter (OOO until 2018)
Modified:
5 years ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, krit, Eric Willigers, f(malita), fs, gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans
Base URL:
ssh://pony.syd/usr/local/google/home/alancutter/repos/chromium/src@_svgRectInterpolationType
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Web Animations: Add SVGNumberListInterpolationType This change migrates the following SVG attribute animations over to SVGNumberListInterpolationType and enables additive keyframe composite modes as well as neutral keyframes: - kernelMatrix - rotate - tableValues - values This is a rebased reupload of: https://codereview.chromium.org/1410343009 BUG=530436 Committed: https://crrev.com/709b4e0d0e112458730e2c500f555681b347a653 Cr-Commit-Position: refs/heads/master@{#361931}

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : composite & neutralKeyframes #

Patch Set 4 : Review changes #

Patch Set 5 : responsive test #

Patch Set 6 : Fix tests #

Patch Set 7 : Fix responsive test derp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+630 lines, -46 lines) Patch
A third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-kernelMatrix-composition.html View 1 2 3 4 5 1 chunk +111 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-rotate-composition.html View 1 2 3 4 5 1 chunk +109 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-tableValues-composition.html View 1 2 3 4 5 1 chunk +109 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-values-composition.html View 1 2 3 4 5 1 chunk +111 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/resources/interpolation-test.js View 1 2 2 chunks +3 lines, -6 lines 0 comments Download
A third_party/WebKit/LayoutTests/animations/svg-attribute-responsive/svg-tableValues-responsive.html View 1 2 3 4 5 6 1 chunk +26 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/core/animation/SVGNumberListInterpolationType.h View 1 2 2 chunks +10 lines, -5 lines 0 comments Download
A third_party/WebKit/Source/core/animation/SVGNumberListInterpolationType.cpp View 1 2 3 4 5 1 chunk +91 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/SVGPointListInterpolationType.cpp View 1 1 chunk +5 lines, -29 lines 0 comments Download
M third_party/WebKit/Source/core/animation/StringKeyframe.cpp View 1 4 chunks +7 lines, -4 lines 0 comments Download
A third_party/WebKit/Source/core/animation/UnderlyingLengthChecker.h View 1 chunk +44 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGNumberList.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGNumberList.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 29 (13 generated)
alancutter (OOO until 2018)
5 years, 1 month ago (2015-11-18 09:27:17 UTC) #2
Eric Willigers
lgtm
5 years, 1 month ago (2015-11-20 02:04:23 UTC) #3
dstockwell
lgtm
5 years ago (2015-11-23 04:29:02 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419733009/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419733009/40001
5 years ago (2015-11-23 23:09:10 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419733009/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419733009/60001
5 years ago (2015-11-23 23:22:23 UTC) #8
Eric Willigers
lgtm
5 years ago (2015-11-23 23:23:08 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419733009/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419733009/80001
5 years ago (2015-11-24 07:20:32 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/139440)
5 years ago (2015-11-24 08:27:44 UTC) #13
dstockwell
lgtm
5 years ago (2015-11-25 05:36:58 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419733009/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419733009/100001
5 years ago (2015-11-25 05:37:21 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/145858)
5 years ago (2015-11-25 07:28:46 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419733009/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419733009/120001
5 years ago (2015-11-26 02:22:51 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) ios_rel_device_ninja on ...
5 years ago (2015-11-26 04:25:45 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419733009/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419733009/120001
5 years ago (2015-11-26 22:52:26 UTC) #26
commit-bot: I haz the power
Committed patchset #7 (id:120001)
5 years ago (2015-11-26 22:57:24 UTC) #27
commit-bot: I haz the power
5 years ago (2015-11-26 22:58:13 UTC) #29
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/709b4e0d0e112458730e2c500f555681b347a653
Cr-Commit-Position: refs/heads/master@{#361931}

Powered by Google App Engine
This is Rietveld 408576698