Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(894)

Issue 1415243004: Separate origin from explanation in HTTP Auth dialogs. (Closed)

Created:
5 years, 2 months ago by meacer
Modified:
4 years, 9 months ago
Reviewers:
palmer, felt
CC:
chromium-reviews, tfarina, dzhioev+watch_chromium.org, achuith+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Separate origin from site provided text in HTTP Auth dialogs. Screenshot: https://drive.google.com/file/d/0B9q2eN9gDoUIVG5ETExTeDRlWFk/view?usp=sharing BUG=544244

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -26 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/login/login_prompt.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/login/login_prompt.cc View 4 chunks +15 lines, -14 lines 2 comments Download
M chrome/browser/ui/views/login_prompt_views.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/login_view.h View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/login_view.cc View 4 chunks +16 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (2 generated)
palmer
5 years, 1 month ago (2015-11-19 23:01:28 UTC) #3
And we'd need to do the same for iOS, Android, and OS X, obviously. (I think
it's best to do those in separate patches, if possible.)

https://codereview.chromium.org/1415243004/diff/1/chrome/browser/ui/login/log...
File chrome/browser/ui/login/login_prompt.cc (right):

https://codereview.chromium.org/1415243004/diff/1/chrome/browser/ui/login/log...
chrome/browser/ui/login/login_prompt.cc:127:
url_formatter::FormatUrlForSecurityDisplay(request_url, languages));
Idea: Use FormatUrlForSecurityDisplayOmitScheme iff IsOriginSecure --> true;
otherwise, FormatUrlForSecurityDisplay.

Idea: Always use FormatUrlForSecurityDisplayOmitScheme; if IsOriginSecure -->
false, use an explanation string that says "This web site is not secure" (or
other bikeshedded string).

I don't know if these are good ideas.

https://codereview.chromium.org/1415243004/diff/1/chrome/browser/ui/login/log...
chrome/browser/ui/login/login_prompt.cc:131:
l10n_util::GetStringFUTF16(IDS_LOGIN_DIALOG_DESCRIPTION, elided_realm);
As I mentioned on the bug, I really would like to not show the realm at all. I
don't like to display untrustworthy strings in browser chrome, which should
contain only trustworthy/verified information.

Powered by Google App Engine
This is Rietveld 408576698