Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Side by Side Diff: chrome/browser/ui/views/login_view.cc

Issue 1415243004: Separate origin from explanation in HTTP Auth dialogs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/login_view.h" 5 #include "chrome/browser/ui/views/login_view.h"
6 6
7 #include "chrome/grit/generated_resources.h" 7 #include "chrome/grit/generated_resources.h"
8 #include "ui/base/l10n/l10n_util.h" 8 #include "ui/base/l10n/l10n_util.h"
9 #include "ui/views/background.h"
9 #include "ui/views/controls/label.h" 10 #include "ui/views/controls/label.h"
10 #include "ui/views/controls/textfield/textfield.h" 11 #include "ui/views/controls/textfield/textfield.h"
11 #include "ui/views/layout/grid_layout.h" 12 #include "ui/views/layout/grid_layout.h"
12 #include "ui/views/layout/layout_constants.h" 13 #include "ui/views/layout/layout_constants.h"
13 14
14 static const int kMessageWidth = 320; 15 static const int kMessageWidth = 320;
15 static const int kTextfieldStackHorizontalSpacing = 30; 16 static const int kTextfieldStackHorizontalSpacing = 30;
16 17
17 using password_manager::LoginModel; 18 using password_manager::LoginModel;
18 using views::GridLayout; 19 using views::GridLayout;
19 20
20 /////////////////////////////////////////////////////////////////////////////// 21 ///////////////////////////////////////////////////////////////////////////////
21 // LoginView, public: 22 // LoginView, public:
22 23
23 LoginView::LoginView(const base::string16& explanation, 24 LoginView::LoginView(const base::string16& authority,
25 const base::string16& explanation,
24 LoginHandler::LoginModelData* login_model_data) 26 LoginHandler::LoginModelData* login_model_data)
25 : username_field_(new views::Textfield()), 27 : username_field_(new views::Textfield()),
26 password_field_(new views::Textfield()), 28 password_field_(new views::Textfield()),
27 username_label_(new views::Label( 29 username_label_(new views::Label(
28 l10n_util::GetStringUTF16(IDS_LOGIN_DIALOG_USERNAME_FIELD))), 30 l10n_util::GetStringUTF16(IDS_LOGIN_DIALOG_USERNAME_FIELD))),
29 password_label_(new views::Label( 31 password_label_(new views::Label(
30 l10n_util::GetStringUTF16(IDS_LOGIN_DIALOG_PASSWORD_FIELD))), 32 l10n_util::GetStringUTF16(IDS_LOGIN_DIALOG_PASSWORD_FIELD))),
33 authority_label_(new views::Label(authority)),
31 message_label_(new views::Label(explanation)), 34 message_label_(new views::Label(explanation)),
32 login_model_(login_model_data ? login_model_data->model : nullptr) { 35 login_model_(login_model_data ? login_model_data->model : nullptr) {
33 password_field_->SetTextInputType(ui::TEXT_INPUT_TYPE_PASSWORD); 36 password_field_->SetTextInputType(ui::TEXT_INPUT_TYPE_PASSWORD);
37
38 authority_label_->SetMultiLine(true);
39 authority_label_->SetHorizontalAlignment(gfx::ALIGN_LEFT);
40 authority_label_->SetAllowCharacterBreak(true);
41
34 message_label_->SetMultiLine(true); 42 message_label_->SetMultiLine(true);
35 message_label_->SetHorizontalAlignment(gfx::ALIGN_LEFT); 43 message_label_->SetHorizontalAlignment(gfx::ALIGN_LEFT);
36 message_label_->SetAllowCharacterBreak(true); 44 message_label_->SetAllowCharacterBreak(true);
45 message_label_->SetEnabledColor(SK_ColorGRAY);
37 46
38 // Initialize the Grid Layout Manager used for this dialog box. 47 // Initialize the Grid Layout Manager used for this dialog box.
39 GridLayout* layout = GridLayout::CreatePanel(this); 48 GridLayout* layout = GridLayout::CreatePanel(this);
40 SetLayoutManager(layout); 49 SetLayoutManager(layout);
41 50
42 // Add the column set for the information message at the top of the dialog 51 // Add the column set for the information message at the top of the dialog
43 // box. 52 // box.
44 const int single_column_view_set_id = 0; 53 const int single_column_view_set_id = 0;
45 views::ColumnSet* column_set = 54 views::ColumnSet* column_set =
46 layout->AddColumnSet(single_column_view_set_id); 55 layout->AddColumnSet(single_column_view_set_id);
47 column_set->AddColumn(GridLayout::FILL, GridLayout::FILL, 1, 56 column_set->AddColumn(GridLayout::FILL, GridLayout::FILL, 1,
48 GridLayout::FIXED, kMessageWidth, 0); 57 GridLayout::FIXED, kMessageWidth, 0);
49 58
50 // Add the column set for the user name and password fields and labels. 59 // Add the column set for the user name and password fields and labels.
51 const int labels_column_set_id = 1; 60 const int labels_column_set_id = 1;
52 column_set = layout->AddColumnSet(labels_column_set_id); 61 column_set = layout->AddColumnSet(labels_column_set_id);
53 column_set->AddPaddingColumn(0, kTextfieldStackHorizontalSpacing); 62 column_set->AddPaddingColumn(0, kTextfieldStackHorizontalSpacing);
54 column_set->AddColumn(views::kControlLabelGridAlignment, GridLayout::CENTER, 63 column_set->AddColumn(views::kControlLabelGridAlignment, GridLayout::CENTER,
55 0, GridLayout::USE_PREF, 0, 0); 64 0, GridLayout::USE_PREF, 0, 0);
56 column_set->AddPaddingColumn(0, views::kRelatedControlHorizontalSpacing); 65 column_set->AddPaddingColumn(0, views::kRelatedControlHorizontalSpacing);
57 column_set->AddColumn(GridLayout::FILL, GridLayout::CENTER, 1, 66 column_set->AddColumn(GridLayout::FILL, GridLayout::CENTER, 1,
58 GridLayout::USE_PREF, 0, 0); 67 GridLayout::USE_PREF, 0, 0);
59 column_set->AddPaddingColumn(0, kTextfieldStackHorizontalSpacing); 68 column_set->AddPaddingColumn(0, kTextfieldStackHorizontalSpacing);
60 69
61 layout->StartRow(0, single_column_view_set_id); 70 layout->StartRow(0, single_column_view_set_id);
62 layout->AddView(message_label_); 71 layout->AddView(authority_label_);
72 if (!explanation.empty()) {
73 layout->AddPaddingRow(0, views::kRelatedControlVerticalSpacing);
74 layout->StartRow(0, single_column_view_set_id);
75 layout->AddView(message_label_);
76 }
63 77
64 layout->AddPaddingRow(0, views::kUnrelatedControlLargeVerticalSpacing); 78 layout->AddPaddingRow(0, views::kUnrelatedControlLargeVerticalSpacing);
65 79
66 layout->StartRow(0, labels_column_set_id); 80 layout->StartRow(0, labels_column_set_id);
67 layout->AddView(username_label_); 81 layout->AddView(username_label_);
68 layout->AddView(username_field_); 82 layout->AddView(username_field_);
69 83
70 layout->AddPaddingRow(0, views::kRelatedControlVerticalSpacing); 84 layout->AddPaddingRow(0, views::kRelatedControlVerticalSpacing);
71 85
72 layout->StartRow(0, labels_column_set_id); 86 layout->StartRow(0, labels_column_set_id);
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
113 127
114 void LoginView::OnLoginModelDestroying() { 128 void LoginView::OnLoginModelDestroying() {
115 login_model_->RemoveObserver(this); 129 login_model_->RemoveObserver(this);
116 login_model_ = NULL; 130 login_model_ = NULL;
117 } 131 }
118 132
119 const char* LoginView::GetClassName() const { 133 const char* LoginView::GetClassName() const {
120 return "LoginView"; 134 return "LoginView";
121 } 135 }
122 136
OLDNEW
« chrome/browser/ui/login/login_prompt.cc ('K') | « chrome/browser/ui/views/login_view.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698