Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: chrome/browser/ui/login/login_prompt.h

Issue 1415243004: Separate origin from explanation in HTTP Auth dialogs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/login/login_prompt.h
diff --git a/chrome/browser/ui/login/login_prompt.h b/chrome/browser/ui/login/login_prompt.h
index faad1940488032b3aae45c26d6f0410612edb4b4..dff8879439068dfa20f2cc44783ad49b1b08c019 100644
--- a/chrome/browser/ui/login/login_prompt.h
+++ b/chrome/browser/ui/login/login_prompt.h
@@ -62,12 +62,14 @@ class LoginHandler : public content::ResourceDispatcherHostLoginDelegate,
// Use this to build a view with password manager support. |password_manager|
// must not be null.
void BuildViewWithPasswordManager(
+ const base::string16& authority,
const base::string16& explanation,
password_manager::PasswordManager* password_manager,
const autofill::PasswordForm& observed_form);
// Use this to build a view without password manager support.
- void BuildViewWithoutPasswordManager(const base::string16& explanation);
+ void BuildViewWithoutPasswordManager(const base::string16& authority,
+ const base::string16& explanation);
// Returns the WebContents that needs authentication.
content::WebContents* GetWebContentsForLogin() const;
@@ -103,7 +105,8 @@ class LoginHandler : public content::ResourceDispatcherHostLoginDelegate,
// Implement this to initialize the underlying platform specific view. If
// |login_model_data| is not null, the contained LoginModel and PasswordForm
// can be used to register the view.
- virtual void BuildViewImpl(const base::string16& explanation,
+ virtual void BuildViewImpl(const base::string16& authority,
+ const base::string16& explanation,
LoginModelData* login_model_data) = 0;
// Sets |model_data.model| as |login_model_| and registers |this| as an

Powered by Google App Engine
This is Rietveld 408576698