Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issue 1414793018: Revert of Converted video frame and image callbacks to use new sync tokens. (Closed)

Created:
5 years, 1 month ago by nhiroki
Modified:
5 years, 1 month ago
CC:
cc-bugs_chromium.org, chromium-reviews, danakj+watch_chromium.org, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, jbauman+watch_chromium.org, kalyank, mcasas+watch_chromium.org, miu+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, piman+watch_chromium.org, posciak+watch_chromium.org, sievers+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Converted video frame and image callbacks to use new sync tokens. (patchset #9 id:160001 of https://codereview.chromium.org/1429213002/ ) Reason for revert: This could be breaking webkit_tests: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20%28dbg%29/builds/4445 http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.7%20%28dbg%29/builds/25461 Original issue's description: > Converted video frame and image callbacks to use new sync tokens. > > As an incremental step towards utilizing the new sync tokens, this > CL converts existing video frame and image sync points to use > sync tokens instead. > > In order to accomplish this, the GpuCommandBufferMsg_CreateImage > IPC message has been modified to accept a fence_release parameter > so that it can act as a sync token IPC. > > A new SyncPointClientWaiter concept has also added which can wait > on other sync point clients without an associated order number. > This only works because the SyncPointClientWaiter cannot be waited > on so no deadlocks can occur. > > BUG=514815 > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/c7aff68a0c11820cc2b8d488851c682c0d32cd2b > Cr-Commit-Position: refs/heads/master@{#357997} TBR=dcheng@chromium.org,dalecurtis@chromium.org,piman@chromium.org,sky@chromium.org,dyen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=514815 Committed: https://crrev.com/a1ab22a90140fe9e6c669998f3efc52795e569e2 Cr-Commit-Position: refs/heads/master@{#358008}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -322 lines) Patch
M cc/resources/video_resource_updater.cc View 1 chunk +6 lines, -7 lines 0 comments Download
M cc/test/test_gpu_memory_buffer_manager.h View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/test/test_gpu_memory_buffer_manager.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M components/mus/gles2/mojo_gpu_memory_buffer_manager.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/mus/gles2/mojo_gpu_memory_buffer_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/gpu/browser_gpu_memory_buffer_manager.h View 3 chunks +4 lines, -4 lines 0 comments Download
M content/browser/gpu/browser_gpu_memory_buffer_manager.cc View 7 chunks +13 lines, -13 lines 0 comments Download
M content/browser/gpu/gpu_process_host.h View 2 chunks +1 line, -5 lines 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_controller.cc View 1 chunk +1 line, -3 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.h View 2 chunks +1 line, -5 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/child_gpu_memory_buffer_manager.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/child_gpu_memory_buffer_manager.cc View 3 chunks +6 lines, -7 lines 0 comments Download
M content/common/child_process_host_impl.h View 2 chunks +1 line, -5 lines 0 comments Download
M content/common/child_process_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/child_process_messages.h View 2 chunks +1 line, -2 lines 0 comments Download
M content/common/gpu/client/command_buffer_proxy_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/gpu/client/command_buffer_proxy_impl.cc View 4 chunks +19 lines, -38 lines 0 comments Download
M content/common/gpu/client/gl_helper.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/common/gpu/client/gl_helper.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M content/common/gpu/client/gpu_channel_host.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/client/gpu_channel_host.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M content/common/gpu/client/gpu_memory_buffer_impl.h View 4 chunks +4 lines, -5 lines 0 comments Download
M content/common/gpu/client/gpu_memory_buffer_impl.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M content/common/gpu/client/gpu_memory_buffer_impl_shared_memory_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/gpu_channel_manager.h View 3 chunks +1 line, -4 lines 0 comments Download
M content/common/gpu/gpu_channel_manager.cc View 2 chunks +11 lines, -17 lines 0 comments Download
M content/common/gpu/gpu_command_buffer_stub.h View 2 chunks +5 lines, -3 lines 0 comments Download
M content/common/gpu/gpu_command_buffer_stub.cc View 2 chunks +5 lines, -11 lines 0 comments Download
M content/common/gpu/gpu_messages.h View 3 chunks +9 lines, -14 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M content/renderer/media/video_capture_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu_memory_buffer_impl_test_template.h View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/client/gles2_implementation.cc View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/client/gpu_memory_buffer_manager.h View 2 chunks +2 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/in_process_command_buffer.h View 1 chunk +1 line, -3 lines 0 comments Download
M gpu/command_buffer/service/in_process_command_buffer.cc View 5 chunks +26 lines, -63 lines 0 comments Download
M gpu/command_buffer/service/sync_point_manager.h View 3 chunks +0 lines, -28 lines 0 comments Download
M gpu/command_buffer/service/sync_point_manager.cc View 1 chunk +0 lines, -23 lines 0 comments Download
M media/base/video_frame.h View 1 chunk +1 line, -1 line 0 comments Download
M media/base/video_frame.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/video_frame_unittest.cc View 3 chunks +5 lines, -11 lines 0 comments Download
M media/renderers/skcanvas_video_renderer.cc View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
nhiroki
Created Revert of Converted video frame and image callbacks to use new sync tokens.
5 years, 1 month ago (2015-11-05 05:54:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414793018/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414793018/1
5 years, 1 month ago (2015-11-05 05:55:06 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-05 05:56:18 UTC) #3
commit-bot: I haz the power
5 years, 1 month ago (2015-11-05 05:57:04 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a1ab22a90140fe9e6c669998f3efc52795e569e2
Cr-Commit-Position: refs/heads/master@{#358008}

Powered by Google App Engine
This is Rietveld 408576698