Remove some Isolate::current_zone() calls, as it gets the zone from mutator thread not the current …

Remove some Isolate::current_zone() calls, as it gets the zone from mutator thread not the current thread

BUG=
R=zra@google.com

Committed: https://github.com/dart-lang/sdk/commit/465cf10a7ce04045b68ad4cf1995ed913a536386

[srdjan, 2015-10-16 22:28:17]

srdjan@google.com changed reviewers:
+ zra@google.com

[zra, 2015-10-16 22:41:47]

IIRC, we started explicitly passing the zone to avoid slow TLS lookups. Does
switching these back have any effect on performance?

https://codereview.chromium.org/1414493003/diff/20001/runtime/vm/dart_api_imp...
File runtime/vm/dart_api_impl.cc (right):

https://codereview.chromium.org/1414493003/diff/20001/runtime/vm/dart_api_imp...
runtime/vm/dart_api_impl.cc:5067: *result = Api::NewHandle(thread->isolate(),
lib.raw());
Does this use the isolate's current zone or the thread's current zone to
allocate the handle?

https://codereview.chromium.org/1414493003/diff/20001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/1414493003/diff/20001/runtime/vm/object.cc#ne...
runtime/vm/object.cc:20932: const TypedData& array =
TypedData::Handle(isolate->current_zone(),
What about this one?

[srdjan, 2015-10-16 23:23:40]

We still want to explicitly pass zones, unless the zone computation at call site
is as expensive as when we do not pass the zone argument. I have restructured
the code more, so that even more Handle allocation pass zone arguments. PTAL.

https://codereview.chromium.org/1414493003/diff/20001/runtime/vm/dart_api_imp...
File runtime/vm/dart_api_impl.cc (right):

https://codereview.chromium.org/1414493003/diff/20001/runtime/vm/dart_api_imp...
runtime/vm/dart_api_impl.cc:5067: *result = Api::NewHandle(thread->isolate(),
lib.raw());
On 2015/10/16 22:41:47, zra wrote:
> Does this use the isolate's current zone or the thread's current zone to
> allocate the handle?

Api's NewHandle are on my TODO list. There is an api_state in isolate that needs
to move to thread.

https://codereview.chromium.org/1414493003/diff/20001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/1414493003/diff/20001/runtime/vm/object.cc#ne...
runtime/vm/object.cc:20932: const TypedData& array =
TypedData::Handle(isolate->current_zone(),
On 2015/10/16 22:41:47, zra wrote:
> What about this one?

Done.

[zra, 2015-10-17 01:47:05]

lgtm

[srdjan, 2015-10-19 17:27:45]

Committed patchset #3 (id:40001) manually as
465cf10a7ce04045b68ad4cf1995ed913a536386 (presubmit successful).