runtime/vm/dart_api_impl.h - Issue 1414493003: Remove some Isolate::current_zone() calls, as it gets the zone from mutator thread not the current …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/dart_api_impl.h

Issue 1414493003: Remove some Isolate::current_zone() calls, as it gets the zone from mutator thread not the current … (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Zones and commentw Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/dart_api_impl.h

diff --git a/runtime/vm/dart_api_impl.h b/runtime/vm/dart_api_impl.h

index 613778a93f305b30b15be5a15033d435d2f1b711..dd5920d0539eb09c5bdbebd2dffb7ba3b15e993d 100644

--- a/runtime/vm/dart_api_impl.h

+++ b/runtime/vm/dart_api_impl.h

@@ -269,7 +269,7 @@ class Api : AllStatic {

static void SetWeakHandleReturnValue(NativeArguments* args,

Dart_WeakPersistentHandle retval);

- static RawString* CallEnvironmentCallback(Isolate* isolate,

+ static RawString* CallEnvironmentCallback(Thread* thread,

const String& name);

private:

« no previous file with comments | « runtime/vm/compiler.cc ('k') | runtime/vm/dart_api_impl.cc » ('j') | no next file with comments »