runtime/vm/debugger.cc - Issue 1414493003: Remove some Isolate::current_zone() calls, as it gets the zone from mutator thread not the current …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/debugger.cc

Issue 1414493003: Remove some Isolate::current_zone() calls, as it gets the zone from mutator thread not the current … (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Zones and commentw Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/debugger.cc

diff --git a/runtime/vm/debugger.cc b/runtime/vm/debugger.cc

index a92b4d5238092d1420dee86ed77dd614202bbf3d..79153f47459047bd02ee3931b40bd70b5132d88d 100644

--- a/runtime/vm/debugger.cc

+++ b/runtime/vm/debugger.cc

@@ -2402,10 +2402,10 @@ void Debugger::CollectLibraryFields(const GrowableObjectArray& field_list,

const String& prefix,

bool include_private_fields) {

DictionaryIterator it(lib);

- Object& entry = Object::Handle(isolate_->current_zone());

+ Object& entry = Object::Handle(zone());

Field& field = Field::Handle(zone());

String& field_name = String::Handle(zone());

- PassiveObject& field_value = PassiveObject::Handle(isolate_->current_zone());

+ PassiveObject& field_value = PassiveObject::Handle(zone());

while (it.HasNext()) {

entry = it.GetNext();

if (entry.IsField()) {

« no previous file with comments | « runtime/vm/debugger.h ('k') | runtime/vm/isolate.cc » ('j') | no next file with comments »