Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Side by Side Diff: runtime/vm/debugger.h

Issue 1414493003: Remove some Isolate::current_zone() calls, as it gets the zone from mutator thread not the current … (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Zones and commentw Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/dart_api_impl.cc ('k') | runtime/vm/debugger.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #ifndef VM_DEBUGGER_H_ 5 #ifndef VM_DEBUGGER_H_
6 #define VM_DEBUGGER_H_ 6 #define VM_DEBUGGER_H_
7 7
8 #include "include/dart_tools_api.h" 8 #include "include/dart_tools_api.h"
9 9
10 #include "vm/object.h" 10 #include "vm/object.h"
(...skipping 632 matching lines...) Expand 10 before | Expand all | Expand 10 after
643 const Library& lib, 643 const Library& lib,
644 const String& prefix, 644 const String& prefix,
645 bool include_private_fields); 645 bool include_private_fields);
646 646
647 // Handles any events which pause vm execution. Breakpoints, 647 // Handles any events which pause vm execution. Breakpoints,
648 // interrupts, etc. 648 // interrupts, etc.
649 void Pause(DebuggerEvent* event); 649 void Pause(DebuggerEvent* event);
650 650
651 void HandleSteppingRequest(DebuggerStackTrace* stack_trace); 651 void HandleSteppingRequest(DebuggerStackTrace* stack_trace);
652 652
653 Zone* zone() const { return isolate_->current_zone(); } 653 Zone* zone() const {
654 ASSERT(isolate_->MutatorThreadIsCurrentThread());
655 return isolate_->current_zone();
656 }
654 657
655 Isolate* isolate_; 658 Isolate* isolate_;
656 Dart_Port isolate_id_; // A unique ID for the isolate in the debugger. 659 Dart_Port isolate_id_; // A unique ID for the isolate in the debugger.
657 bool initialized_; 660 bool initialized_;
658 661
659 // ID number generator. 662 // ID number generator.
660 intptr_t next_id_; 663 intptr_t next_id_;
661 664
662 BreakpointLocation* latent_locations_; 665 BreakpointLocation* latent_locations_;
663 BreakpointLocation* breakpoint_locations_; 666 BreakpointLocation* breakpoint_locations_;
(...skipping 30 matching lines...) Expand all
694 697
695 friend class Isolate; 698 friend class Isolate;
696 friend class BreakpointLocation; 699 friend class BreakpointLocation;
697 DISALLOW_COPY_AND_ASSIGN(Debugger); 700 DISALLOW_COPY_AND_ASSIGN(Debugger);
698 }; 701 };
699 702
700 703
701 } // namespace dart 704 } // namespace dart
702 705
703 #endif // VM_DEBUGGER_H_ 706 #endif // VM_DEBUGGER_H_
OLDNEW
« no previous file with comments | « runtime/vm/dart_api_impl.cc ('k') | runtime/vm/debugger.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698