Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1414373002: Move shader precision modifier check onto GLSLCaps (Closed)

Created:
5 years, 2 months ago by egdaniel
Modified:
5 years, 2 months ago
Reviewers:
bsalomon, joshua.litt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Move shader precision modifier check onto GLSLCaps BUG=skia: Committed: https://skia.googlesource.com/skia/+/f529439fea003851d986a0573a7e0465754b2a48

Patch Set 1 #

Patch Set 2 : change inclues #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -80 lines) Patch
M bench/GLInstancedArraysBench.cpp View 1 3 chunks +6 lines, -5 lines 0 comments Download
M bench/GLVec4ScalarBench.cpp View 1 3 chunks +8 lines, -7 lines 0 comments Download
M bench/GLVertexAttributesBench.cpp View 1 5 chunks +10 lines, -9 lines 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M src/effects/gradients/SkGradientShader.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/effects/gradients/SkSweepGradient.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrDefaultGeoProcFactory.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/effects/GrBezierEffect.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrConvexPolyEffect.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldGeoProc.cpp View 11 chunks +24 lines, -29 lines 0 comments Download
M src/gpu/effects/GrTextureDomain.cpp View 1 2 chunks +5 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGLCaps.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/gl/GrGLGLSL.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 2 chunks +7 lines, -7 lines 0 comments Download
M src/gpu/gl/GrGLProgramDataManager.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLShaderVar.h View 1 5 chunks +9 lines, -7 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.h View 1 3 chunks +5 lines, -0 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.cpp View 2 chunks +5 lines, -1 line 0 comments Download
M src/gpu/gl/builders/GrGLShaderBuilder.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/gl/builders/GrGLShaderBuilder.cpp View 1 4 chunks +7 lines, -6 lines 0 comments Download
M src/gpu/glsl/GrGLSLCaps.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/gpu/glsl/GrGLSLCaps.cpp View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
egdaniel
5 years, 2 months ago (2015-10-20 20:53:42 UTC) #2
bsalomon
lgtm
5 years, 2 months ago (2015-10-20 21:56:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414373002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414373002/20001
5 years, 2 months ago (2015-10-21 13:16:59 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/3720) Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, ...
5 years, 2 months ago (2015-10-21 13:17:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414373002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414373002/40001
5 years, 2 months ago (2015-10-21 13:32:16 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-10-21 14:14:20 UTC) #11
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/f529439fea003851d986a0573a7e0465754b2a48

Powered by Google App Engine
This is Rietveld 408576698